-
-
Notifications
You must be signed in to change notification settings - Fork 14
Strip invalid char data from strings on save #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @hahn-kev)
@jasonleenaylor I've added a link to a Wikipedia page documenting valid xml chars. One thing it mentioned is that |
Sorry that I didn't see your comment before, yes we should include that range. It is very likely someone using FieldWorks will have a character in that range. |
@jasonleenaylor I worked with Martin H and rewrote the regex to just match the invalid characters that we want to remove, and he helped me come up with a test case which was outside the normal range. |
relates to #328
I didn't see anything stripping out data, so I've gone ahead and done that via a compiled regex.
This change is