fix: Regenerate requirements to include importlib-resources #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Potentially fixes: #254 |
woodruffw
previously approved these changes
Nov 24, 2025
Member
woodruffw
left a comment
woodruffw
left a comment
There was a problem hiding this comment.
Thanks @ModeSevenIndustrialSolutions!
This looks fine to me, although I'm confused as to how this happened in the first place -- @jku any thoughts?
jku
requested changes
Nov 24, 2025
Member
jku
left a comment
jku
left a comment
There was a problem hiding this comment.
I'm confused as to how this happened in the first place
I am too -- the difference in requirements.txt with different Python versions is not surprising but it should not affect the action since we should always use Python 3.14 for this exact reason...
Let's hold this until we understand why the failure happens
The sigstore 4.1.0 package has a dependency on importlib_resources~=5.7 which wasn't included in the pinned requirements file. When uv pip install runs with --require-hashes mode (implicit when hashes are present), it fails if any transitive dependencies aren't pinned. This regenerates the requirements.txt file to include all transitive dependencies with their hashes, fixing the installation failure. Fixes installation error: ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. Signed-off-by: Matthew Watkins <[email protected]>
ModeSevenIndustrialSolutions
force-pushed
the
fix-importlib-resources
branch
from
fe6da8d to
9aabcb0
Compare
Member
|
I'm tentatively closing this: we can revisit this if current main branch does not work for you -- I believe it should:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sigstore 4.1.0 package has a dependency on importlib_resources~=5.7 which wasn't included in the pinned requirements file. When uv pip install runs with --require-hashes mode (implicit when hashes are present), it fails if any transitive dependencies aren't pinned.
This regenerates the requirements.txt file to include all transitive dependencies with their hashes, fixing the installation failure.
Fixes installation error:
ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==.
Summary
Release Note
Documentation