MVP Axum migration #8118
Open
MVP Axum migration #8118
+227
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macladson
force-pushed
the
axum-migration
branch
2 times, most recently
from
9a133dc to
89d637f
Compare
macladson
force-pushed
the
axum-migration
branch
from
89d637f to
d583525
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR is a minimal version of an Axum migration. It doesn't have any Axum routes yet, it just utilizes a compatibility layer to run Warp filters inside of an Axum-compatible Tower service.
This allows us to migrate routes one at a time which reduces migration burden.
Additional Info
This PR is only to be used for testing performance through the compatibility layer. If the performance cost is acceptable we can start migrating the metrics servers and VC http server first. Leaving the BN server untouched until the others are complete.
I've also disabled TLS for now since Axum doesn't have native support for it.