Skip to content

Add builder blinded_blocks v2 #7778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2025
Merged

Add builder blinded_blocks v2 #7778

merged 3 commits into from
Jul 25, 2025

Conversation

pawanjay176
Copy link
Member

Issue Addressed

Partially addresses #7381

Proposed Changes

Add blinded_blocks v2 method specified in ethereum/builder-specs#123

@pawanjay176 pawanjay176 added work-in-progress PR is a work-in-progress builder API fulu Required for the upcoming Fulu hard fork labels Jul 23, 2025
@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Jul 23, 2025
jimmygchen
jimmygchen reviewed Jul 23, 2025
View reviewed changes
beacon_node/execution_layer/src/lib.rs
debug!(?block_root, "Sending block to builder");
if spec.is_fulu_scheduled() {
Copy link
Member

@jimmygchen jimmygchen Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised a discussion here on whether to switch at the Fulu fork, or when running the node with Fulu scheduled:
https://discord.com/channels/595666850260713488/1395080509775937636/1397431503448969276

IMO it's safer if the switch happens before the fork.

jimmygchen added a commit that referenced this pull request Jul 23, 2025
@jimmygchen
Add builder blinded_blocks v2 (#7778)
2196def 
Squashed commit of the following:

commit 3b8d8e7
Author: Jimmy Chen <[email protected]>
Date:   Wed Jul 23 15:23:25 2025 +1000

    Fix tests.

commit 053d450
Author: Jimmy Chen <[email protected]>
Date:   Wed Jul 23 15:11:03 2025 +1000

    Complete Fulu builder API changes.

commit 661ee56
Author: Pawan Dhananjay <[email protected]>
Date:   Tue Jul 22 18:46:01 2025 -0700

    Initial commit
jimmygchen added a commit that referenced this pull request Jul 23, 2025
@jimmygchen
Add builder blinded_blocks v2 (#7778)
80fce52 
Squashed commit of the following:

commit 3b8d8e7
Author: Jimmy Chen <[email protected]>
Date:   Wed Jul 23 15:23:25 2025 +1000

    Fix tests.

commit 053d450
Author: Jimmy Chen <[email protected]>
Date:   Wed Jul 23 15:11:03 2025 +1000

    Complete Fulu builder API changes.

commit 661ee56
Author: Pawan Dhananjay <[email protected]>
Date:   Tue Jul 22 18:46:01 2025 -0700

    Initial commit
@jimmygchen jimmygchen mentioned this pull request Jul 23, 2025
Draft
pawanjay176 pushed a commit that referenced this pull request Jul 24, 2025
@jimmygchen @pawanjay176
Add builder blinded_blocks v2 (#7778)
744e979 
Squashed commit of the following:

commit 3b8d8e7
Author: Jimmy Chen <[email protected]>
Date:   Wed Jul 23 15:23:25 2025 +1000

    Fix tests.

commit 053d450
Author: Jimmy Chen <[email protected]>
Date:   Wed Jul 23 15:11:03 2025 +1000

    Complete Fulu builder API changes.

commit 661ee56
Author: Pawan Dhananjay <[email protected]>
Date:   Tue Jul 22 18:46:01 2025 -0700

    Initial commit
michaelsproul
michaelsproul approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 25, 2025
mergify bot added a commit that referenced this pull request Jul 25, 2025
@mergify
Merge of #7778
8118fe6
@mergify mergify bot mentioned this pull request Jul 25, 2025
Closed
6 tasks
mergify bot added a commit that referenced this pull request Jul 25, 2025
@mergify
Merge of #7778
92721ef
@mergify mergify bot mentioned this pull request Jul 25, 2025
Closed
6 tasks
@mergify Mergify
Copy link

mergify bot commented Jul 25, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #7795.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Jul 25, 2025
@mergify
Merge of #7778
c407b80
@mergify mergify bot mentioned this pull request Jul 25, 2025
Closed
6 tasks
mergify bot added a commit that referenced this pull request Jul 25, 2025
@mergify
Merge of #7778
21b7c1a
@mergify mergify bot mentioned this pull request Jul 25, 2025
Closed
6 tasks
mergify bot added a commit that referenced this pull request Jul 25, 2025
@mergify
Merge of #7778
54a415a
@jimmygchen jimmygchen mentioned this pull request Jul 25, 2025
Closed
@mergify mergify bot merged commit 09065a8 into sigp:unstable Jul 25, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen left review comments

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
builder API fulu Required for the upcoming Fulu hard fork fusaka-devnet-3 ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawanjay176 @jimmygchen @michaelsproul