Disconnect on error #580
Open
Disconnect on error #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR changes the error handling in BaseCall so that WebSocket errors trigger a reconnection instead of immediately hanging up the call.
- Replace
this.hangup()calls in two catch blocks with_disconnectAndReconnect() - Add a private
_disconnectAndReconnect()method that emits aSwEvent.SocketErrorfor automatic recovery
Comments suppressed due to low confidence (2)
packages/common/src/webrtc/BaseCall.ts:988
- Add unit or integration tests to cover the new
_disconnectAndReconnectlogic, verifying that WebSocket errors correctly trigger the reconnection event.
private _disconnectAndReconnect() {
packages/common/src/webrtc/BaseCall.ts:988
- [nitpick] Include a JSDoc comment for
_disconnectAndReconnectdescribing its purpose and parameters, improving readability and maintainability.
private _disconnectAndReconnect() {
briankwest
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't hang up the call due to execution errors. Instead this we disconnect from the WebSocket and let the recovery logic restart. In this case, after subscribing, the server will send a new verto.attach, allowing the client to build a new answer.