Skip to content

#6069 - Double encoding Open Graph Characters #6072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarlowBrown
Copy link
Contributor

@MarlowBrown MarlowBrown commented Jun 21, 2025

Contributor checklist

  • My commits are rebased on the latest main branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
  • iPhone 12, iOS 18.4

Description

This pull request fixes #6069 by redecoding a string containing OpenGraph characters. Originally, a string that looks like:

Not quoted, "Quoted" and "Better quoted"

Was encoded as:

Not quoted, "Quoted" and \"Better quoted\"

However, there are still OpenGraph (&quot) tags in the string. This PR redecodes a string up to a maximum of 3 times to make sure that all OpenGraph tags have been consumed.

Before:
Screenshot 2025-06-20 at 10 25 50 PM

After:
Screenshot 2025-06-20 at 10 27 01 PM

(cherry picked from commit 079b499f73729b607841e65ff64e5088418707f5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants