introduce CMP_RAT_CTX to hold OSSL_CMP_CTX, impl RATs#122
Open
Akretsch wants to merge 1 commit into
Open
Conversation
Akretsch
changed the title
DDvO
requested changes
May 21, 2026
DDvO
left a comment
DDvO
left a comment
Member
There was a problem hiding this comment.
Please avoid extending OSSL_CMP_CTX,
as this should not be needed at all -
please keep all RAT-related data local in cmpClient().
There are various memory leaks, at least in error cases.
See also further comments in #121 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
see #121 , but with less modifications as proposed by @rajeev-0