refactor(dashboard): explicitly define change detection strategy#2198
refactor(dashboard): explicitly define change detection strategy#2198spliffone wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the dashboard components to utilize Angular Signals for state management, specifically updating properties like hide, dashboardFrameEndPadding, and _isExpanded. The review feedback recommends renaming _isExpanded to isExpandedSignal to comply with ESLint naming conventions without needing to disable linting rules. Additionally, it is noted that the manual markForCheck() call can be removed since updating the dashboardFrameEndPadding signal automatically triggers change detection.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
b281be5 to
cf2f5f1
Compare
cf2f5f1 to
b2b694b
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the dashboard and its various widgets to use ChangeDetectionStrategy.OnPush for optimized change detection. It also migrates several properties, such as hide, dashboardFrameEndPadding, and isExpanded, to Angular Signals, updating the corresponding templates, component logic, and unit tests to call them as functions. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
spike-rabbit
left a comment
There was a problem hiding this comment.
same here, please do not change to OnPush as this may breaks mutation on single properties of input objects.
b2b694b to
d38b025
Compare
d38b025 to
8c6e734
Compare
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: