Skip to content

refactor(dashboard): explicitly define change detection strategy#2198

Open
spliffone wants to merge 1 commit into
mainfrom
refactor/dashboard-card-explicit-change-detection-strategy
Open

refactor(dashboard): explicitly define change detection strategy#2198
spliffone wants to merge 1 commit into
mainfrom
refactor/dashboard-card-explicit-change-detection-strategy

Conversation

@spliffone

@spliffone spliffone commented Jun 19, 2026

Copy link
Copy Markdown
Member

@spliffone spliffone requested review from a team as code owners June 19, 2026 09:55

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the dashboard components to utilize Angular Signals for state management, specifically updating properties like hide, dashboardFrameEndPadding, and _isExpanded. The review feedback recommends renaming _isExpanded to isExpandedSignal to comply with ESLint naming conventions without needing to disable linting rules. Additionally, it is noted that the manual markForCheck() call can be removed since updating the dashboardFrameEndPadding signal automatically triggers change detection.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread projects/element-ng/dashboard/si-dashboard.component.ts Outdated
Comment thread projects/element-ng/dashboard/si-dashboard.component.ts Outdated
Comment thread projects/element-ng/dashboard/si-dashboard.component.html Outdated
Comment thread projects/element-ng/dashboard/si-dashboard.component.html Outdated
Comment thread projects/element-ng/dashboard/si-dashboard.component.ts Outdated
Comment thread projects/element-ng/dashboard/si-dashboard.component.ts Outdated
Comment thread projects/element-ng/dashboard/si-dashboard.component.ts Outdated
Comment thread projects/element-ng/dashboard/si-dashboard.component.ts
@spliffone spliffone marked this pull request as draft June 19, 2026 09:59
@spliffone spliffone force-pushed the refactor/dashboard-card-explicit-change-detection-strategy branch from b281be5 to cf2f5f1 Compare June 21, 2026 11:30
@spliffone spliffone marked this pull request as ready for review June 21, 2026 11:31
@spliffone spliffone force-pushed the refactor/dashboard-card-explicit-change-detection-strategy branch from cf2f5f1 to b2b694b Compare June 21, 2026 11:49
@spliffone

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the dashboard and its various widgets to use ChangeDetectionStrategy.OnPush for optimized change detection. It also migrates several properties, such as hide, dashboardFrameEndPadding, and isExpanded, to Angular Signals, updating the corresponding templates, component logic, and unit tests to call them as functions. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@spike-rabbit spike-rabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, please do not change to OnPush as this may breaks mutation on single properties of input objects.

@spliffone spliffone force-pushed the refactor/dashboard-card-explicit-change-detection-strategy branch from b2b694b to d38b025 Compare June 22, 2026 06:58
@spliffone spliffone force-pushed the refactor/dashboard-card-explicit-change-detection-strategy branch from d38b025 to 8c6e734 Compare June 22, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants