refactor(content-action-bar): explicitly define change detection stra…#2197
refactor(content-action-bar): explicitly define change detection stra…#2197spliffone wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures the si-content-action-bar.component.ts component to use ChangeDetectionStrategy.OnPush. The reviewer noted that switching to OnPush may prevent asynchronous updates to plain properties (such as parentElement in ngAfterViewInit) from triggering change detection, and recommended converting parentElement to a signal to ensure UI updates are properly reflected.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
we should only change this with v51 to OnPush
spliffone
force-pushed
the
refactor/content-action-bar-explicit-change-detection-strategy
branch
from
fe4a377 to
f3be3eb
Compare
…detection-strategy
2 participants
…tegy
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: