Skip to content

docs(main-detail-container): move configuration controls into card#2182

Draft
spike-rabbit wants to merge 4 commits into
mainfrom
docs/main-detail-container-controls-card
Draft

docs(main-detail-container): move configuration controls into card#2182
spike-rabbit wants to merge 4 commits into
mainfrom
docs/main-detail-container-controls-card

Conversation

@spike-rabbit

@spike-rabbit spike-rabbit commented Jun 18, 2026

Copy link
Copy Markdown
Member

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the settings forms in the main-detail container examples to use si-form-item components and ngModel bindings, importing FormsModule and SiFormItemComponent in the process. Feedback highlights an invalid [ngModel] property binding in si-main-detail-container-block.html that will cause a compilation error, as well as violations of the Siemens UX writing guidelines regarding capitalization for the 'Resizable Parts' labels, which should be in sentence case ('Resizable parts').

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/app/examples/si-main-detail-container/si-main-detail-container-block.html Outdated
Comment thread src/app/examples/si-main-detail-container/si-main-detail-container-block.html Outdated
Comment thread src/app/examples/si-main-detail-container/si-main-detail-container.html Outdated
@spike-rabbit spike-rabbit force-pushed the docs/main-detail-container-controls-card branch from 42c006a to c655c9b Compare June 18, 2026 17:57
@spike-rabbit spike-rabbit force-pushed the docs/main-detail-container-controls-card branch from 21dd0ba to d87adbe Compare June 19, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant