Skip to content

refactor(collapsible-panel): update icon sizes#1504

Draft
dauriamarco wants to merge 1 commit into
mainfrom
fix/collasible-panel-icon-size
Draft

refactor(collapsible-panel): update icon sizes#1504
dauriamarco wants to merge 1 commit into
mainfrom
fix/collasible-panel-icon-size

Conversation

@dauriamarco

Copy link
Copy Markdown
Member

Updates the icon size of collapsible-panel to 24px.


@dauriamarco dauriamarco added this to the 49.x milestone Feb 11, 2026
@dauriamarco dauriamarco self-assigned this Feb 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates icon sizes in collapsible-panel and side-panel for consistency, changing them to 24px. The changes involve updating CSS classes from icon to icon-lg in the relevant HTML templates and making a minor layout adjustment. A security audit identified a Medium severity Cross-Site Scripting (XSS) vulnerability related to the si-icon component's use of a dangerous innerHTML binding, and the reviewed files pass potentially untrusted data to it. Although this PR did not introduce the underlying flaw, its modifications to code using this component increase the importance of addressing this security concern.

Comment thread projects/element-ng/accordion/si-collapsible-panel.component.html
Comment thread projects/element-ng/side-panel/si-side-panel-content.component.html
@github-actions

Copy link
Copy Markdown

@panch1739

Copy link
Copy Markdown
Member

@spike-rabbit @dauriamarco im not sure we should put this in 24px...i guess that you are doing it because the vertical nav has 24px...but, in the case of the side panel it looks odd. Im not sure, @hbxes WDYT?

@dauriamarco dauriamarco Feb 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panch1739 @hbxes @spike-rabbit continuing the conversation here: I don’t necessarily prefer larger icons in general, but when navbar-vertical and side-panel are shown in the same layout (see screenshots), the size difference is noticeable. Using different icon sizes makes spacing and alignment feel slightly inconsistent.

To me, it feels more coherent if both components use the same sizing and spacing, either small in both cases or large in both, rather than mixing the two. But the final call is yours 👌

With the same size:

Image

With different sizes:

Image Image

@hbxes

hbxes commented Feb 12, 2026

Copy link
Copy Markdown
Member

@spike-rabbit @dauriamarco im not sure we should put this in 24px...i guess that you are doing it because the vertical nav has 24px...but, in the case of the side panel it looks odd. Im not sure, @hbxes WDYT?

Yea, it looks really odd, when the side panel is present, maybe we have to reconsider the navbar and use there also 20px, to keep it consistant

@dauriamarco dauriamarco added the ux Marks all UX related topics (UX team is working on or UX input is required) label Feb 13, 2026
@dauriamarco dauriamarco force-pushed the fix/collasible-panel-icon-size branch from 3fff7fe to 1d43833 Compare February 16, 2026 13:08
@github-actions

Copy link
Copy Markdown

Code Coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ux Marks all UX related topics (UX team is working on or UX input is required)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants