refactor(tabs): use siTooltip instead of title#1425
Open
dauriamarco wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to add tooltip support to tabs. However, the current change in si-tab.component.html removes the existing title attribute, which provides the native browser tooltip, and replaces it with aria-label. While this improves accessibility for screen reader users, it's a regression for mouse users who rely on tooltips for icon-only tabs. My review includes a suggestion to re-introduce the title attribute alongside aria-label to support both use cases.
|
Documentation. Coverage Reports: |
dauriamarco
commented
Feb 3, 2026
dauriamarco
changed the title
siTooltip instead of title
dauriamarco
force-pushed
the
feat/tooltip-tabs
branch
from
4ea03ca to
113b503
Compare
spike-rabbit
requested changes
Feb 4, 2026
dauriamarco
force-pushed
the
feat/tooltip-tabs
branch
3 times, most recently
from
fb4c07c to
04bc578
Compare
chintankavathia
requested changes
Feb 6, 2026
dauriamarco
force-pushed
the
feat/tooltip-tabs
branch
2 times, most recently
from
0ddfed7 to
292e6bb
Compare
dauriamarco
force-pushed
the
feat/tooltip-tabs
branch
from
292e6bb to
2261c6f
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tooltip support to tabs.