Skip to content

refactor: remove simpl type alias #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
akashsonune wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor: remove simpl type alias #1332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions api-goldens/charts-ng/common/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,16 +293,14 @@ export class SiChartBaseComponent implements AfterViewInit, OnChanges, OnInit, O
export { SingleAxisComponentOption }

// @public (undocumented)
interface SiSeriesOption {
export interface SiSeriesOption {
// (undocumented)
customLegendToolTip?: string;
// (undocumented)
displayName?: string;
// (undocumented)
visible?: boolean;
}
export { SiSeriesOption }
export { SiSeriesOption as SimplSeriesOption }

export { SunburstSeriesOption }

Expand Down
4 changes: 1 addition & 3 deletions api-goldens/charts-ng/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@ import * as i8 from '@siemens/charts-ng/sunburst';
import * as i9 from '@siemens/charts-ng/custom-legend';

// @public @deprecated (undocumented)
class SiChartsNgModule {
export class SiChartsNgModule {
}
export { SiChartsNgModule }
export { SiChartsNgModule as SimplChartsNgModule }


export * from "@siemens/charts-ng/cartesian";
Expand Down
8 changes: 2 additions & 6 deletions api-goldens/live-preview/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,12 +336,10 @@ export abstract class SiLivePreviewLocaleApi {
}

// @public
class SiLivePreviewModule {
export class SiLivePreviewModule {
// (undocumented)
static forRoot(config: SiLivePreviewConfig, isMobile?: boolean): ModuleWithProviders<SiLivePreviewModule>;
}
export { SiLivePreviewModule }
export { SiLivePreviewModule as SimplLivePreviewModule }

// @public (undocumented)
export class SiLivePreviewQrComponent implements AfterViewInit, OnDestroy, OnChanges {
Expand Down Expand Up @@ -388,10 +386,8 @@ export class SiLivePreviewRendererComponent implements OnChanges, OnDestroy {
}

// @public (undocumented)
class SiLivePreviewRoutingModule {
export class SiLivePreviewRoutingModule {
}
export { SiLivePreviewRoutingModule }
export { SiLivePreviewRoutingModule as SimplLivePreviewRoutingModule }

// @public (undocumented)
export abstract class SiLivePreviewThemeApi {
Expand Down
4 changes: 1 addition & 3 deletions api-goldens/native-charts-ng/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,8 @@ import * as i0 from '@angular/core';
import * as i1 from '@siemens/native-charts-ng/gauge';

// @public (undocumented)
class SiNativeChartsNgModule {
export class SiNativeChartsNgModule {
}
export { SiNativeChartsNgModule }
export { SiNativeChartsNgModule as SimplNativeChartsNgModule }


export * from "@siemens/native-charts-ng/gauge";
Expand Down
2 changes: 0 additions & 2 deletions projects/charts-ng/common/si-chart.interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,5 +108,3 @@ export interface SiSeriesOption {
customLegendToolTip?: string;
visible?: boolean;
}

export type { SiSeriesOption as SimplSeriesOption };
2 changes: 0 additions & 2 deletions projects/charts-ng/public-api.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,3 @@ import { SiChartSunburstComponent } from '@siemens/charts-ng/sunburst';
]
})
export class SiChartsNgModule {}

export { SiChartsNgModule as SimplChartsNgModule };

@gemini-code-assist gemini-code-assist Bot Jan 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing this alias is a good cleanup. However, the migration schematic mapping for SimplChartsNgModule still exists in projects/element-ng/schematics/ts-import-to-siemens-migration/mappings/charts-ng-mappings.ts. Since this alias is being removed, the mapping is now likely obsolete and should probably be removed as well to avoid issues with the migration schematic.

2 changes: 0 additions & 2 deletions projects/live-preview/live-preview-routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,3 @@ export const livePreviewRoutes: Routes = [
exports: [RouterModule]
})
export class SiLivePreviewRoutingModule {}

export { SiLivePreviewRoutingModule as SimplLivePreviewRoutingModule };
2 changes: 0 additions & 2 deletions projects/live-preview/public-api.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,3 @@ export class SiLivePreviewModule {
};
}
}

export { SiLivePreviewModule as SimplLivePreviewModule };
2 changes: 0 additions & 2 deletions projects/maps-ng/src/public-api.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,3 @@ import { SiMapModule } from './components/si-map/index';
exports: [SiMapModule]
})
export class SiMapsNgModule {}

export { SiMapsNgModule as SimplMapsNgModule };

@gemini-code-assist gemini-code-assist Bot Jan 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to other removals in this PR, while removing this alias is correct, the corresponding entry for SimplMapsNgModule in projects/element-ng/schematics/ts-import-to-siemens-migration/mappings/maps-ng-mappings.ts seems to have been missed. Please consider removing it to keep the migration schematics consistent.

2 changes: 0 additions & 2 deletions projects/native-charts-ng/public-api.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,3 @@ import { SiNChartGaugeComponent } from '@siemens/native-charts-ng/gauge';
exports: [SiNChartGaugeComponent]
})
export class SiNativeChartsNgModule {}

export { SiNativeChartsNgModule as SimplNativeChartsNgModule };

@gemini-code-assist gemini-code-assist Bot Jan 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The removal of the SimplNativeChartsNgModule alias is a good step. However, a corresponding entry still exists in projects/element-ng/schematics/ts-import-to-siemens-migration/mappings/native-charts-ng-mappings.ts. This should likely be removed to prevent the migration schematic from referencing a non-existent export.

Loading