feat: warn user about join token being in use during revoke/delete #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oguzkilcan
approved these changes
Aug 5, 2025
The UI now shows warning if the token revoke/delete operation will render some machines not able to connect. Same thing was done for the CLI commands. Fixes: siderolabs#1380 Signed-off-by: Artem Chernyshev <[email protected]> Signed-off-by: Edward Sammut Alessi <[email protected]>
Slessi
force-pushed
the
warn-token-usage
branch
from
b6ea7dd to
fe5d028
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI now shows warning if the token revoke/delete operation will render some machines not able to connect.
Same thing was done for the CLI commands.
Fixes: #1380