Skip to content

Conversation

@fsgh42
Copy link
Member

@fsgh42 fsgh42 commented Oct 28, 2025

update out of date applications

@fsgh42 fsgh42 force-pushed the chore/update-example-omni branch 4 times, most recently from 3fbb48f to 5e2176a Compare October 28, 2025 13:47
@fsgh42 fsgh42 marked this pull request as ready for review October 28, 2025 13:58
@fsgh42 fsgh42 requested a review from TimJones October 28, 2025 13:58
@github-project-automation github-project-automation bot moved this to To Do in Planning Oct 28, 2025
@talos-bot talos-bot moved this from To Do to In Review in Planning Oct 28, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the ArgoCD patch removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 addition, 22,500 deletions not shown because the diff is too large. Please use a local Git client to view these changes.

It's a single line now after updating the file (as described in the file itself).
It was multi line before, so there is +1, -22k lines being changed.

If you want, I can try to make it multiline again, we should do it consistent over all files then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I misread the diff then.
If we can make it multiline (and thus readable) that would be preferable, and the same with the cilium patch as you say. But since it's semi-auto-generated I don't care that much and it wouldn't be a blocker to merge the PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see what I can do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimJones ok so I spent an hour tinkering with this and was able to restore argo multidoc, the cilium case is really tricky due to the way yq is build. I don't think it is possible to do, actually.

I will leave it as is.

Copy link
Member

@TimJones TimJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits.

@github-project-automation github-project-automation bot moved this from In Review to Approved in Planning Oct 28, 2025
@fsgh42 fsgh42 force-pushed the chore/update-example-omni branch from 5e2176a to 715a3a3 Compare October 28, 2025 19:08
Copy link
Member Author

@fsgh42 fsgh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimJones addressed your remarks (nice catch, ty). see if it looks good now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 addition, 22,500 deletions not shown because the diff is too large. Please use a local Git client to view these changes.

It's a single line now after updating the file (as described in the file itself).
It was multi line before, so there is +1, -22k lines being changed.

If you want, I can try to make it multiline again, we should do it consistent over all files then.

@fsgh42 fsgh42 force-pushed the chore/update-example-omni branch 3 times, most recently from e483432 to 1ec22e8 Compare October 30, 2025 14:53
@fsgh42 fsgh42 force-pushed the chore/update-example-omni branch from 1ec22e8 to 1c40817 Compare October 30, 2025 14:59
@fsgh42
Copy link
Member Author

fsgh42 commented Oct 30, 2025

/m

@talos-bot talos-bot merged commit 1c40817 into main Oct 30, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Planning Oct 30, 2025
@fsgh42 fsgh42 deleted the chore/update-example-omni branch October 30, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants