-
Notifications
You must be signed in to change notification settings - Fork 45
chore: update omni example resources #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3fbb48f to
5e2176a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the ArgoCD patch removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 addition, 22,500 deletions not shown because the diff is too large. Please use a local Git client to view these changes.
It's a single line now after updating the file (as described in the file itself).
It was multi line before, so there is +1, -22k lines being changed.
If you want, I can try to make it multiline again, we should do it consistent over all files then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I misread the diff then.
If we can make it multiline (and thus readable) that would be preferable, and the same with the cilium patch as you say. But since it's semi-auto-generated I don't care that much and it wouldn't be a blocker to merge the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll see what I can do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimJones ok so I spent an hour tinkering with this and was able to restore argo multidoc, the cilium case is really tricky due to the way yq is build. I don't think it is possible to do, actually.
I will leave it as is.
TimJones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits.
5e2176a to
715a3a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimJones addressed your remarks (nice catch, ty). see if it looks good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 addition, 22,500 deletions not shown because the diff is too large. Please use a local Git client to view these changes.
It's a single line now after updating the file (as described in the file itself).
It was multi line before, so there is +1, -22k lines being changed.
If you want, I can try to make it multiline again, we should do it consistent over all files then.
e483432 to
1ec22e8
Compare
1ec22e8 to
1c40817
Compare
|
/m |
update out of date applications