chore: update talos to v1.12.0-beta.0 #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run rekres to regenerate configs. Signed-off-by: Mateusz Urbanek <[email protected]>
shanduur
force-pushed
the
chore-v1.12.0-beta.0
branch
4 times, most recently
from
b348b78 to
43ee484
Compare
shanduur
force-pushed
the
chore-v1.12.0-beta.0
branch
2 times, most recently
from
bef85c8 to
bf2c097
Compare
shanduur
force-pushed
the
chore-v1.12.0-beta.0
branch
9 times, most recently
from
5ae9619 to
32858ee
Compare
shanduur
commented
Nov 18, 2025
| assert.Equal(t, "192.168.0.0/16,fdaa:bbbb:cccc:15::/64", strings.Join(provider.Cluster().Network().ServiceCIDRs(), ",")) | ||
| }) | ||
|
|
||
| t.Run("ConfigPatches", func(t *testing.T) { |
Member
Author
There was a problem hiding this comment.
This will always fail, as v1.12.0 is always multi-config (we always have HostnameConfig generated).
frezbo
reviewed
Nov 18, 2025
| if scope.Config.Spec.Hostname.Source == v1alpha3.HostnameSourceMachineName { | ||
| data.RawV1Alpha1().MachineConfig.MachineNetwork.NetworkHostname = scope.ConfigOwner.GetName() | ||
| if parseErr == nil && talosVersion.GreaterThanEqual(semver.MustParse("1.12.0-beta.0")) { | ||
| patches = append(patches, fmt.Sprintf("apiVersion: v1alpha1\nkind: HostnameConfig\nauto: off\nhostname: %s", scope.ConfigOwner.GetName())) |
Member
There was a problem hiding this comment.
can't we use NewHostNameConfig and use string from it?
frezbo
approved these changes
Nov 18, 2025
Update talos to v1.12.0-beta.0 Signed-off-by: Mateusz Urbanek <[email protected]>
shanduur
force-pushed
the
chore-v1.12.0-beta.0
branch
from
32858ee to
8141779
Compare
Member
Author
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes siderolabs/talos#12183