Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78
Summary
bb setup browsercommandBB_BROWSERexport and optionally persist it to the user's shell rc filebrowser_fetchdetection logic frombb-toolsWhy
We considered making browser installation/configuration happen implicitly during every
npm install, but that is too heavy and surprising for a large optional runtime dependency.An explicit setup flow is safer and clearer:
browser_fetchcan work on this machineBB_BROWSERCommand examples
Testing
cargo test -p bb-cli setup -- --nocapturecargo test -p bb-tools browser_fetch -- --nocapturecargo run -q -p bb-cli -- setup browser --helpcargo run -q -p bb-cli -- setup browser