Skip to content

fix(templates): avoid type cast and add no-cms fallback in FrontendLandingPage #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maciek Kucmus (mkucmus) merged 4 commits into from
May 28, 2026
Merged

fix(templates): avoid type cast and add no-cms fallback in FrontendLandingPage #2464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38b4e62
fix(templates): avoid type cast and add no-cms fallback in FrontendLa…
mkucmus May 27, 2026
ec35249
Merge branch 'main' into fix/landing-page-type-cast
mkucmus May 27, 2026
ff2f897
Merge branch 'main' into fix/landing-page-type-cast
mkucmus May 28, 2026
5027035
fix(templates): address review - error message fallback and dedupe nu…
mkucmus May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions templates/vue-demo-store/app/components/FrontendLandingPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<script setup lang="ts">
import { getCmsBreadcrumbs } from "@shopware/helpers";
import { useLandingSearch } from "#imports";
import type { Schemas } from "#shopware";

const props = defineProps<{
navigationId: string;
Expand All @@ -11,32 +10,33 @@ const { search } = useLandingSearch();

const { data: landingResponse, error } = await useAsyncData(
`cmsLanding${props.navigationId}`,
async () => {
const landingPage = await search(props.navigationId, {
withCmsAssociations: true,
});
return landingPage;
},
() => search(props.navigationId, { withCmsAssociations: true }),
);

if (landingResponse.value) {
const breadcrumbs = getCmsBreadcrumbs(landingResponse.value);
useBreadcrumbs(breadcrumbs);
}

if (!landingResponse?.value) {
console.error("[FrontendLandingPage.vue]", error.value?.message);
if (!landingResponse.value) {
const statusMessage = error.value?.message || "No landing page found";
console.error("[FrontendLandingPage.vue]", statusMessage);
throw createError({
statusCode: 500,
message: error.value?.message,
message: statusMessage,
});
Comment on lines +16 to 22
}

const landingPage = landingResponse as Ref<Schemas["LandingPage"]>;
useCmsHead(landingPage, { mainShopTitle: "Shopware Frontends Demo Store" });
const landingPage = landingResponse.value;

useBreadcrumbs(getCmsBreadcrumbs(landingPage));
useCmsHead(
computed(() => landingPage),
{
mainShopTitle: "Shopware Frontends Demo Store",
},
);
</script>

<template>
<LayoutBreadcrumbs />
<CmsPage v-if="landingResponse?.cmsPage" :content="landingResponse.cmsPage" />
<div v-else class="container mx-auto bg-white flex flex-col">
<span>😱 cmsPage is missing.</span>
</div>
</template>
34 changes: 17 additions & 17 deletions templates/vue-starter-template/app/components/FrontendLandingPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<script setup lang="ts">
import { getCmsBreadcrumbs } from "@shopware/helpers";
import { useLandingSearch } from "#imports";
import type { Schemas } from "#shopware";

const props = defineProps<{
navigationId: string;
Expand All @@ -11,32 +10,33 @@ const { search } = useLandingSearch();

const { data: landingResponse, error } = await useAsyncData(
`cmsLanding${props.navigationId}`,
async () => {
const landingPage = await search(props.navigationId, {
withCmsAssociations: true,
});
return landingPage;
},
() => search(props.navigationId, { withCmsAssociations: true }),
);

if (landingResponse.value) {
const breadcrumbs = getCmsBreadcrumbs(landingResponse.value);
useBreadcrumbs(breadcrumbs);
}

if (!landingResponse?.value) {
console.error("[FrontendLandingPage.vue]", error.value?.message);
if (!landingResponse.value) {
const statusMessage = error.value?.message || "No landing page found";
console.error("[FrontendLandingPage.vue]", statusMessage);
throw createError({
statusCode: 500,
message: error.value?.message,
message: statusMessage,
});
Comment on lines +16 to 22
}

const landingPage = landingResponse as Ref<Schemas["LandingPage"]>;
useCmsHead(landingPage, { mainShopTitle: "Shopware Frontends Demo Store" });
const landingPage = landingResponse.value;

useBreadcrumbs(getCmsBreadcrumbs(landingPage));
useCmsHead(
computed(() => landingPage),
{
mainShopTitle: "Shopware Frontends Demo Store",
},
);
</script>

<template>
<LayoutBreadcrumbs />
<CmsPage v-if="landingResponse?.cmsPage" :content="landingResponse.cmsPage" />
<div v-else class="container mx-auto bg-white flex flex-col">
<span>😱 cmsPage is missing.</span>
</div>
</template>