fix: swagger tag added, additionalTags null fix#116
Open
Hardik-hi wants to merge 1 commit intoshiksha-platform:mainfrom
Open
fix: swagger tag added, additionalTags null fix#116Hardik-hi wants to merge 1 commit intoshiksha-platform:mainfrom
Hardik-hi wants to merge 1 commit intoshiksha-platform:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added Swagger API tag for announcements APIs
Issue: Announcements tag not visible in swagger ui, API descriptions nested under default tag (https://sandbox.shikshaplatform.io/api/swagger-docs)
Expected: Tag should be visible like other modules
Fix: Added
@ApiTags("Announcements")in Announcement Controller, UI now looks as follows:Bugfix for additionalTags
Bug: When additionalTags is undefined during creation of announcement, value of additional_tags being set as ["undefined"] in DB
Expected: Value in DB should be set as NULL
Fix: removed template literals to send empty array in case of undefined value to DB
CC: @Shruti3004 @coolbung