Fixes #490 - Add support for Namecheap #501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Link to Issue #490 |
eloekset
force-pushed
the
feature/namecheap-to-upstream
branch
from
3a51a14 to
2817068
Compare
shibayan
requested changes
Dec 18, 2022
| dnsProviders.TryAdd(options.Gandi, o => new GandiProvider(o)); | ||
| dnsProviders.TryAdd(options.GoDaddy, o => new GoDaddyProvider(o)); | ||
| dnsProviders.TryAdd(options.GoogleDns, o => new GoogleDnsProvider(o)); | ||
| dnsProviders.TryAdd(options.Namecheap, o => new NamecheapProvider(o, HttpClientFactory.Create(), HttpClientFactory.Create())); |
Owner
There was a problem hiding this comment.
HttpClient should be instantiated inside the Provider. Implementation uniformity with other Providers is important.
| public const string GetHostsCommand = "namecheap.domains.dns.getHosts"; | ||
| public const string SetHostsCommand = "namecheap.domains.dns.setHosts"; | ||
|
|
||
| public NamecheapProvider(NamecheapOptions options, HttpClient namecheapHttpClient, HttpClient ipfyOrgHttpClient) |
Owner
There was a problem hiding this comment.
As with other Providers, the implementation of the IDnsProvider interface should be separated from the DNS API implementation class.
This is necessary for implementation consistency as well as to be resilient to future API changes.
|
|
||
| var ipFyResponse = await response.Content.ReadAsAsync<IpfyResponse>(); | ||
|
|
||
| return ipFyResponse.Ip; |
Owner
There was a problem hiding this comment.
Azure Functions do not always match the Outbound IP between each request. Therefore, there is a possibility of unintended behavior when the obtained Outbound IP changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implemenation for Namecheap.
I've deployed and used it for three of my own domains now and it works fine.
Since I can't send PRs for the wiki, this is the documentation that should be added about configuration of the Namecheap provider:
Namecheap
App settings
Acmebot:Namecheap:ApiKeyAcmebot:Namecheap:ApiKeyExample API Token configuration
Navigate to https://ap.www.namecheap.com/settings/tools/apiaccess/
Client IP addresses must be whitelisted in your Namecheap account to be able to call the API. For Azure Function apps, this is a bit tricky, because you don't know which IP address the function app uses until it has tried and got rejected.
To find the IP address, you'll have to look at the Application Insights Performance view and look for logs on GetZones. There you should find an entry for api.namecheap.com GET /xml.response and the Path contains the ClientIp=nn.nnn.nn.nnn parameter showing the IP address that was used.
You have to go to your Namecheap profile page and whitelist this IP address.
But there's no guarantee that the function app uses the same IP address when it renews the certificates some months later.