fix(button): ensure consistent height across all button variants #7554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VladimirKobranov is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
shadcn
requested changes
Jun 7, 2025
shadcn
added
component: button
area: roadmap
|
Added fix in v4 new-york |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the issue?
When using different button variants (like default and outline) together, they have slightly different heights because the outline variant has a border while others don't. This causes annoying layout shifts, especially noticeable in components like tabs where you switch between button states.
The fix
Added a transparent border to all button variants so they're all the same height. The outline variant still looks the same (it just overrides the transparent border with a visible one), but now all buttons have consistent dimensions.
Why this matters
Prevents layout jumps when switching between button variants