fix(use-mobile): prefer globalThis over window (#10999)#11000
Open
Dodothereal wants to merge 1 commit into
Open
fix(use-mobile): prefer globalThis over window (#10999)#11000Dodothereal wants to merge 1 commit into
Dodothereal wants to merge 1 commit into
Conversation
Replaces bare 'window' references in use-mobile.ts (and the matching registry templates) with 'globalThis'. Matches the existing pattern already used elsewhere in the codebase (e.g. use-media-query and use-locale-storage) and resolves SonarQube's rule against referencing 'window' directly. Closes shadcn-ui#10999
Contributor
|
@Dodothereal is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Can you sign the commits please? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10999
Summary
Replaces bare
windowreferences inuse-mobile.ts(and the three matching registry templates underapps/v4/registry/.../hooks/use-mobile.ts) withglobalThis. This matches the pattern already used elsewhere in the codebase (e.g.use-media-query,use-locale-storage) and resolves the SonarQube violation reported in the issue.globalThisresolves to the samewindowobject in browsers but works in environments wherewindowis not defined, mirroring how the codebase already tolerates SSR/Node environments.Test plan
pnpm test --filter @workspace/v4 -- use-mobile(usesglobalThisandwindowinterchangeably — behavior is identical)isMobiletoggles on/off at the breakpoint.AI assistance
Generated-by: Dodothereal with Anthropic's Claude.
Reviewed and edited by hand.