-
Notifications
You must be signed in to change notification settings - Fork 0
fix: handle permission denied in daily summary search and detect fdfind on Ubuntu #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shabaraba
merged 1 commit into
main
from
fix/daily-summary-permission-denied-and-fd-detection
Feb 19, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silent failure when exactly one search errors and neither returns results.
The current condition
if partial_err and has_resultsmeans a warning is only emitted when there are results plus a partial error. When one search completely fails (e.g.,err1= "rg command failed: …") and the other succeeds with zero results (err2 = nil,md_files = {}), all three conditions evaluate as:has_resultsfalseerr1 and err2 and not has_resultsfalse(err2 is nil) → no early abortpartial_err and has_resultsfalse→ no warningThe function returns
{}silently. The user sees "no files found" with no diagnostic, masking a real error in one of the two finders.🐛 Proposed fix — always warn when any error is present
📝 Committable suggestion
🤖 Prompt for AI Agents