-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[RL] enable offloading hybrid linear attn model #13336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RL] enable offloading hybrid linear attn model #13336
Conversation
Summary of ChangesHello @zhuzilin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing memory management for hybrid linear attention models, particularly to facilitate Reinforcement Learning (RL) with models such as Qwen3Next. It achieves this by integrating a memory saver mechanism directly into the Mamba pool's initialization process and ensuring that memory saving configurations are consistently applied throughout the memory allocation components. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly enables memory offloading for hybrid linear attention models. The changes are well-targeted and effectively integrate torch-memory-saver for both the Mamba pool and the full attention KV pool within the hybrid model. By wrapping the Mamba pool allocation in a memory saver region and propagating the enable_memory_saver flag to the HybridLinearKVPool, the PR ensures that memory-intensive components can be offloaded, which is crucial for running large models in memory-constrained environments like reinforcement learning setups. The implementation is clean and follows existing patterns in the codebase. I have no further comments.

Motivation
This PR is trying to offload the mamba pool within the hybrid model so that we can correctly do RL on models like Qwen3Next.
Thank you for your time on reviewing this PR :)
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist