Skip to content

Conversation

@slin1237
Copy link
Collaborator

Checklist

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the sgl-router crate's configuration by eliminating the explicit grpc-client feature flag. By making gRPC client functionality a default inclusion, it simplifies the build process and ensures that this core capability is always present without requiring specific feature activation.

Highlights

  • Feature Flag Removal: The grpc-client and grpc-server feature flags have been entirely removed from the sgl-router/Cargo.toml file, simplifying the build configuration.
  • Default gRPC Client: The grpc_client module in sgl-router/src/lib.rs is no longer conditionally compiled based on the grpc-client feature flag, making gRPC client functionality a default and always-available component.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file model-gateway labels Nov 15, 2025
@slin1237 slin1237 force-pushed the grpc-feature-remove branch from c1fbeaa to fb7fc64 Compare November 15, 2025 11:03
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the grpc-client and grpc-server feature flags, making gRPC support a core, non-optional component of the sglang-router crate. The changes in Cargo.toml correctly remove the feature definitions, and the change in sgl-router/src/lib.rs removes the conditional compilation for the grpc_client module. These changes are straightforward and correctly implement the goal of making gRPC support integral to the router. The code is clean and I have not found any issues with this change.

@slin1237 slin1237 merged commit 37c8761 into main Nov 15, 2025
36 of 37 checks passed
@slin1237 slin1237 deleted the grpc-feature-remove branch November 15, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file model-gateway run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants