-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[model-gateway] move python to binding folder #13295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant structural reorganization of the project by relocating all Python language bindings into a new, dedicated Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the Python bindings into a dedicated bindings/python directory, which is a good structural improvement for supporting other language bindings in the future. The changes mostly involve moving files and updating paths in various configuration files.
My review has identified a couple of issues:
- The
pre-committarget in theMakefileis broken as it references abench-quicktarget that has been removed. - The new
README.mdfor the Python bindings contains confusing instructions regarding build and test commands.
I've provided suggestions to fix these issues. Overall, the refactoring is well-executed, but these small fixes are needed to ensure the developer workflow is not broken and the documentation is clear.
0339b5e to
a48a56d
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the project structure by moving the Python bindings into a dedicated bindings/python directory. This is a good step towards supporting bindings for other languages. The changes mostly involve moving files and updating configuration files like Cargo.toml, Makefile, and pyproject.toml.
My review focuses on the correctness and consistency of these configuration changes. I've found a few minor issues:
- There are some inconsistencies in the development build commands in the README files.
- The
Makefilehas a small inefficiency in thepython-checktarget.
Overall, this is a well-executed refactoring. Addressing the minor points I've raised will improve the developer experience.
131a8c8 to
3099136
Compare
we intended to introduce other language bindings including
thus re-organizing bindings to dedicated folder with language name
Checklist