chore: run from artefact url

tests/automation/create_user.spec.ts

@@ -14,8 +14,8 @@ sessionTestOneWindow('Create User', async ([window]) => {
   await sleepFor(100, true);
   // check username matches
   await waitForTestIdWithText(window, 'your-profile-name', userA.userName);
-  // check session id matches
-  await waitForTestIdWithText(window, 'your-session-id', userA.accountid);
+  // check Account ID matches
+  await waitForTestIdWithText(window, 'your-account-id', userA.accountid);
   // exit profile modal
   await clickOnTestIdWithText(window, 'modal-close-button');
   // go to settings section

tests/automation/disappearing_message_checks.spec.ts

@@ -237,7 +237,7 @@ test_Alice_1W_Bob_1W(
     // To stop the layout shift
     await sleepFor(500);
     await clickOnTestIdWithText(aliceWindow1, 'conversation-options-avatar');
-    await clickOnTestIdWithText(aliceWindow1, 'add-user-button');
+    await clickOnTestIdWithText(aliceWindow1, 'invite-contacts-menu-option');
     await waitForTestIdWithText(
       aliceWindow1,
       'modal-heading',

tests/automation/disappearing_messages.spec.ts

@@ -311,7 +311,7 @@ test_Alice_2W_Bob_1W(
     await clickOnElement({
       window: aliceWindow1,
       strategy: 'data-testid',
-      selector: 'disappearing-messages',
+      selector: 'disappearing-messages-menu-option',
       maxWait: 100,
     });
     await clickOnElement({

tests/automation/enforce_localized_str.spec.ts

@@ -202,8 +202,6 @@ function getExpectedStringFromKey(
       return 'Your IP is visible to your call partner and a Session Technology Foundation server while using beta calls.';
     case 'blockDescription':
       return 'Are you sure you want to block {name}? Blocked users cannot send you message requests, group invites or call you.';
-    case 'conversationsDeleteDescription':
-      return 'Are you sure you want to delete your conversation with {name}? New messages from {name} will start a new conversation.';
     case 'noteToSelfHide':
       return 'Hide Note to Self';
     case 'noteToSelfHideDescription':
@@ -236,6 +234,14 @@ function getExpectedStringFromKey(
       return 'View QR';
     case 'recoveryPasswordView':
       return 'View Password';
+    case 'deleteConversationDescription':
+      return 'Are you sure you want to delete your conversation with {name}? This will permanently delete all messages and attachments.';
+    case 'manageMembers':
+      return 'Manage Members';
+    case 'recoveryPasswordHidePermanentlyDescription1':
+      return 'Without your recovery password, you cannot load your account on new devices. We strongly recommend you save your recovery password in a safe and secure place before continuing.';
+    case 'recoveryPasswordHidePermanentlyDescription2':
+      return 'Are you sure you want to permanently hide your recovery password on this device? This cannot be undone.';
     default:
       // returning nul means we don't have an expected string yet for this key.
       // This will make the test fail

tests/automation/group_testing.spec.ts

@@ -75,7 +75,7 @@ test_group_Alice_1W_Bob_1W_Charlie_1W_Dracula_1W(
     await clickOnElement({
       window: aliceWindow1,
       strategy: 'data-testid',
-      selector: 'add-user-button',
+      selector: 'invite-contacts-menu-option',
     });
     // Waiting for animation of right panel to appear
     await sleepFor(1000);
@@ -140,8 +140,7 @@ test_group_Alice_1W_Bob_1W_Charlie_1W(
     // Click on edit group name
     await clickOnTestIdWithText(aliceWindow1, 'conversation-options-avatar');
     await clickOnTestIdWithText(aliceWindow1, 'edit-group-name');
-    await typeIntoInput(aliceWindow1, 'group-name-input', '     ');
-    await aliceWindow1.keyboard.press('Enter');
+    await clickOnTestIdWithText(aliceWindow1, 'clear-group-info-name-button');
     await waitForTestIdWithText(aliceWindow1, 'error-message');
     const actualError = await grabTextFromElement(
       aliceWindow1,
@@ -157,10 +156,7 @@ test_group_Alice_1W_Bob_1W_Charlie_1W(
       aliceWindow1,
       englishStrippedStr('cancel').toString(),
     );
-    await clickOnTestIdWithText(
-      aliceWindow1,
-      'back-button-conversation-options',
-    );
+    await clickOnTestIdWithText(aliceWindow1, 'modal-close-button');
   },
 );
 

tests/automation/input_validations.spec.ts

@@ -38,11 +38,11 @@ import {
     await clickOnTestIdWithText(window, 'existing-account-button');
     await typeIntoInput(window, 'recovery-phrase-input', incorrectSeed);
     await clickOnTestIdWithText(window, 'continue-button');
-    await waitForTestIdWithText(window, 'session-error-message');
+    await waitForTestIdWithText(window, 'error-message');
     const actualError = await grabTextFromElement(
       window,
       'data-testid',
-      'session-error-message',
+      'error-message',
     );
     if (actualError !== expectedError) {
       throw new Error(
@@ -74,11 +74,11 @@ import {
       await clickOnTestIdWithText(window, 'create-account-button');
       await typeIntoInput(window, 'display-name-input', displayName);
       await clickOnTestIdWithText(window, 'continue-button');
-      await waitForTestIdWithText(window, 'session-error-message');
+      await waitForTestIdWithText(window, 'error-message');
       const actualError = await grabTextFromElement(
         window,
         'data-testid',
-        'session-error-message',
+        'error-message',
       );
       if (testName === 'No name') {
         console.log('Expected failure: see SES-2832');

tests/automation/landing_page.spec.ts

@@ -3,6 +3,12 @@ import { compareScreenshot, waitForElement } from './utilities/utils';
 
 export type ElementState = 'new-account' | 'restored-account';
 
+// TODO: Normalize screenshot dimensions before comparison to handle different pixel densities (e.g. with sharp)
+// This would fix MacBook Retina (2x) vs M4 Mac Mini (1x) pixel density differences (1000x1584 vs 500x792)
+// Alternatives: 
+// - Try to set deviceScaleFactor: 1 in Playwright context to force consistent scaling 
+// - Record pixel density dependent screenshots 
+
 test_Alice_2W(
   `Landing page states`,
   async ({ aliceWindow1, aliceWindow2 }, testInfo) => {

tests/automation/linked_device_group.spec.ts

@@ -106,12 +106,12 @@ test_group_Alice_1W_Bob_1W_Charlie_1W(
     // Check for group members
     await clickOnTestIdWithText(aliceWindow2, 'conversation-options-avatar');
     // Check right panel has correct name
-    await waitForTestIdWithText(aliceWindow2, 'right-panel-group-name');
-    await clickOnTestIdWithText(aliceWindow2, 'group-members');
+    await waitForTestIdWithText(aliceWindow2, 'group-name');
+    await clickOnTestIdWithText(aliceWindow2, 'manage-members-menu-option');
     await waitForTestIdWithText(
       aliceWindow2,
       'modal-heading',
-      englishStrippedStr('groupMembers').toString(),
+      englishStrippedStr('manageMembers').toString(),
     );
     // Check for You, Bob and Charlie
     await Promise.all([
@@ -181,7 +181,7 @@ test_group_Alice_1W_Bob_1W_Charlie_1W(
     );
     // Check for group members
     await clickOnTestIdWithText(aliceWindow2, 'conversation-options-avatar');
-    await clickOnTestIdWithText(aliceWindow2, 'group-members');
+    await clickOnTestIdWithText(aliceWindow2, 'manage-members-menu-option');
     // Check for You, Bob and Charlie
     await Promise.all([
       waitForTestIdWithText(
@@ -193,6 +193,7 @@ test_group_Alice_1W_Bob_1W_Charlie_1W(
       waitForTestIdWithText(aliceWindow2, 'contact', charlie.userName),
     ]);
     await clickOnTestIdWithText(aliceWindow2, 'session-confirm-cancel-button');
+    await clickOnTestIdWithText(aliceWindow2, 'modal-close-button');
     // Delete device data on alicewindow2
     await clearDataOnWindow(aliceWindow2);
     const [restoredWindow] = await openApp(1);
@@ -217,7 +218,7 @@ test_group_Alice_1W_Bob_1W_Charlie_1W(
     );
     // Check for group members
     await clickOnTestIdWithText(restoredWindow, 'conversation-options-avatar');
-    await clickOnTestIdWithText(restoredWindow, 'group-members');
+    await clickOnTestIdWithText(restoredWindow, 'manage-members-menu-option');
     // Check for You, Bob and Charlie
     await Promise.all([
       waitForTestIdWithText(
@@ -233,6 +234,7 @@ test_group_Alice_1W_Bob_1W_Charlie_1W(
       restoredWindow,
       'session-confirm-cancel-button',
     );
+    await clickOnTestIdWithText(restoredWindow, 'modal-close-button');
     // Delete device data on restoredWindow
     await clearDataOnWindow(restoredWindow);
     const [restoredWindow2] = await openApp(1);
@@ -257,7 +259,7 @@ test_group_Alice_1W_Bob_1W_Charlie_1W(
     );
     // Check for group members
     await clickOnTestIdWithText(restoredWindow2, 'conversation-options-avatar');
-    await clickOnTestIdWithText(restoredWindow2, 'group-members');
+    await clickOnTestIdWithText(restoredWindow2, 'manage-members-menu-option');
     // Check for You, Bob and Charlie
     await Promise.all([
       waitForTestIdWithText(

tests/automation/linked_device_user.spec.ts

@@ -41,10 +41,10 @@ sessionTestOneWindow('Link a device', async ([aliceWindow1]) => {
       'your-profile-name',
       userA.userName,
     );
-    // Verify Session ID
+    // Verify Account ID
     await waitForTestIdWithText(
       aliceWindow1,
-      'your-session-id',
+      'your-account-id',
       userA.accountid,
     );
     // exit profile modal
@@ -161,7 +161,7 @@ test_Alice_2W(
         });
         // This file is saved in `Profile-picture-syncs` folder
         expect(screenshot).toMatchSnapshot({
-          name: 'avatar-updated-blue.jpeg',
+          name: `avatar-updated-blue.jpeg`,
         });
         correctScreenshot = true;
         console.info(
@@ -407,7 +407,7 @@ test_Alice_2W_Bob_1W(
     await checkModalStrings(
       aliceWindow1,
       englishStrippedStr('conversationsDelete').toString(),
-      englishStrippedStr('conversationsDeleteDescription')
+      englishStrippedStr('deleteConversationDescription')
         .withArgs({ name: bob.userName })
         .toString(),
     );
@@ -501,7 +501,7 @@ test_Alice_2W(
         aliceWindow2,
         'data-testid',
         'module-conversation__user__profile-name',
-        8000,
+        10000,
         englishStrippedStr('noteToSelf').toString(),
       ),
     ]);

tests/automation/message_checks.spec.ts

@@ -122,7 +122,7 @@ test_Alice_1W_Bob_1W(
     await createContact(aliceWindow1, bobWindow1, alice, bob);
     await joinCommunity(aliceWindow1);
     await clickOnTestIdWithText(aliceWindow1, 'conversation-options-avatar');
-    await clickOnTestIdWithText(aliceWindow1, 'add-user-button');
+    await clickOnTestIdWithText(aliceWindow1, 'invite-contacts-menu-option');
     await waitForTestIdWithText(
       aliceWindow1,
       'modal-heading',

tests/automation/setup/new_user.ts

@@ -33,9 +33,9 @@ export const newUser = async (
   // await clickOnTestIdWithText(window, 'modal-close-button');
   await clickOnTestIdWithText(window, 'leftpane-primary-avatar');
 
-  // Save session ID to a variable
-  let accountid = await window.innerText('[data-testid=your-session-id]');
-  accountid = accountid.replace(/(\r\n|\n|\r)/gm, ''); // remove the new line in the SessionID as it is rendered with one forced
+  // Save Account ID to a variable
+  let accountid = await window.innerText('[data-testid=your-account-id]');
+  accountid = accountid.replace(/(\r\n|\n|\r)/gm, ''); // remove the new line in the Account ID as it is rendered with one forced
 
   console.log(
     `${userName}: Account ID: "${chalk.blue(

tests/automation/types/testing.ts

@@ -77,6 +77,7 @@ export type MediaType = 'image' | 'video' | 'audio' | 'file';
 export type Strategy = 'data-testid' | 'class' | ':has-text';
 
 // Would be good to find a way to sort those with prettier
+// TODO sort with eslint plugin perfectionist
 export type DataTestId =
   | 'session-id-signup'
   | 'display-name-input'
@@ -89,7 +90,6 @@ export type DataTestId =
   | 'control-message'
   | 'disappear-control-message'
   | 'disappearing-messages-indicator'
-  | 'back-button-conversation-options'
   | 'conversation-options-avatar'
   | 'settings-section'
   | 'clear-data-settings-menu-item'
@@ -107,7 +107,7 @@ export type DataTestId =
   | 'disappearing-messages-dropdown'
   | 'session-toast'
   | 'accept-message-request'
-  | 'confirm-nickname'
+  | 'set-nickname-confirm-button'
   | 'nickname-input'
   | 'three-dots-conversation-options'
   | 'message-section'
@@ -142,22 +142,20 @@ export type DataTestId =
   | 'new-closed-group-name'
   | 'create-group-button'
   | 'link-device'
-  | 'group-name-input'
-  | 'right-panel-group-name'
+  | 'update-group-info-name-input'
+  | 'group-name'
   | 'header-conversation-name'
   | 'copy-button-profile-update'
   | 'loading-spinner'
   | 'empty-conversation-notification'
   | 'your-profile-name'
-  | 'your-session-id'
   | 'mentions-popup-row'
   | 'enable-read-receipts'
   | 'disappear-set-button'
   | 'disappear-after-read-option'
-  | 'disappearing-messages'
+  | 'disappearing-messages-menu-option'
   | 'disappear-after-send-option'
   | 'disappear-set-button'
-  | 'add-user-button'
   | 'message-content'
   | 'group-update-message'
   | 'message-request-response-message'
@@ -168,7 +166,6 @@ export type DataTestId =
   | 'existing-account-button'
   | 'context-menu-item'
   | 'modal-description'
-  | 'session-error-message'
   | DMTimeOption
   | `input-${DMTimeOption}`
   | 'disappear-messages-type-and-time'
@@ -189,6 +186,8 @@ export type DataTestId =
   | 'link-preview-image'
   | 'link-preview-title'
   | 'error-message'
-  | 'group-members'
+  | 'manage-members-menu-option'
   | 'session-confirm-cancel-button'
-  | 'session-recovery-password';
+  | 'session-recovery-password'
+  | 'invite-contacts-menu-option'
+  | 'clear-group-info-name-button';

tests/automation/user_actions.spec.ts

@@ -162,6 +162,12 @@ test_Alice_1W_no_network('Change username', async ({ aliceWindow1 }) => {
   await clickOnTestIdWithText(aliceWindow1, 'modal-close-button');
 });
 
+// TODO: Normalize screenshot dimensions before comparison to handle different pixel densities (e.g. with sharp)
+// This would fix MacBook Retina (2x) vs M4 Mac Mini (1x) pixel density differences (56x56 vs 28x28)
+// Alternatives: 
+// - Try to set deviceScaleFactor: 1 in Playwright context to force consistent scaling 
+// - Record pixel density dependent screenshots 
+
 test_Alice_1W_no_network(
   'Change avatar',
   async ({ aliceWindow1 }, testInfo) => {
@@ -248,7 +254,7 @@ test_Alice_1W_Bob_1W(
     await sleepFor(100);
     await clickOnTestIdWithText(
       aliceWindow1,
-      'confirm-nickname',
+      'set-nickname-confirm-button',
       englishStrippedStr('save').toString(),
     );
     await sleepFor(1000);
@@ -370,7 +376,7 @@ test_Alice_1W_Bob_1W(
     await checkModalStrings(
       aliceWindow1,
       englishStrippedStr('conversationsDelete').toString(),
-      englishStrippedStr('conversationsDeleteDescription')
+      englishStrippedStr('deleteConversationDescription')
         .withArgs({ name: bob.userName })
         .toString(),
     );

tests/automation/utilities/rename_group.ts

@@ -16,11 +16,11 @@ export const renameGroup = async (
   await clickOnMatchingText(window, oldGroupName);
   await clickOnTestIdWithText(window, 'conversation-options-avatar');
   await clickOnTestIdWithText(window, 'edit-group-name');
-  await typeIntoInput(window, 'group-name-input', newGroupName);
+  await typeIntoInput(window, 'update-group-info-name-input', newGroupName);
   await window.keyboard.press('Enter');
-  await clickOnMatchingText(window, englishStrippedStr('okay').toString());
-  await waitForTestIdWithText(window, 'right-panel-group-name', newGroupName);
-  await clickOnTestIdWithText(window, 'back-button-conversation-options');
+  await clickOnMatchingText(window, englishStrippedStr('save').toString());
+  await waitForTestIdWithText(window, 'group-name', newGroupName);
+  await clickOnTestIdWithText(window, 'modal-close-button');
   // Check config message
   await waitForMatchingText(
     window,