Skip to content

Conversation

Mingun
Copy link
Contributor

@Mingun Mingun commented May 29, 2025

Adjacently tagged enums with many struct variants should get most benefit from that.

@Mingun
Copy link
Contributor Author

Mingun commented Jun 7, 2025

@dtolnay, @oli-obk, could you look at this simple optimization?

@Mingun
Copy link
Contributor Author

Mingun commented Sep 18, 2025

@dtolnay, @oli-obk mind to merge this very simple optimization (the second commit does the job). Expanding of variant_arms variable performed twice which creates duplication. The effect especially visible when struct variants are used, because they generate a lot of code.

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay dtolnay merged commit 2dbeefb into serde-rs:master Sep 20, 2025
14 checks passed
@Mingun Mingun deleted the dedupe-adj-enums branch September 21, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants