Skip to content

Conversation

@sepandhaghighi
Copy link
Owner

Reference Issues/PRs

#168

What does this implement/fix? Explain your changes.

  • --bg-color argument added

Any other comments?

@sepandhaghighi sepandhaghighi self-assigned this Dec 1, 2025
@sepandhaghighi sepandhaghighi added the enhancement New feature or request label Dec 1, 2025
@sepandhaghighi sepandhaghighi added this to the mytimer v2.4 milestone Dec 1, 2025
@sepandhaghighi sepandhaghighi marked this pull request as ready for review December 1, 2025 09:46
Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. The only problem I observed is that the way it works is different for the first print compared to other prints. I attached the pictures below. Not a big deal, but it's worth exploring if it can be fixed.

The first print

Image

Prints after

Image

@sepandhaghighi
Copy link
Owner Author

It looks good. The only problem I observed is that the way it works is different for the first print compared to other prints. I attached the pictures below. Not a big deal, but it's worth exploring if it can be fixed.

@sadrasabouri
Yes, I dealt with this issue. However, at the moment, I don't have a straightforward solution for it. Consider that different terminal environments react differently with colorama.

@sadrasabouri sadrasabouri merged commit 3383429 into dev Dec 3, 2025
26 checks passed
@sadrasabouri sadrasabouri deleted the bg-color branch December 3, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants