add pagination to worker counts, preserves backwards compatibility #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
There was a problem hiding this comment.
If backwards compatibility is not an issue, the count should default to 25 like the rest of the paginated methods. When both offset and count are 0, it gets the entire data set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With any significant number of workers (we have 1300, soon to be 8K+), workers.counts becomes unwieldy, especially in the qless ruby client's webui.
I tried to preserve backwards compatibility, so workers.counts without any args returns the entire set like it did before.
I also tried to match existing signatures that have pagination (e.g. offset, count as arguments).
However, as a result of the above two requirements (?) the QlessWorker.counts argument processing is a little hokey - basically I check wether the first arg is a number to determine wether the user intended to paginate all or get a single worker.