Skip to content

Address issues#90

Open
pollytur wants to merge 15 commits intosensorium-competition:mainfrom
pollytur:address_issues
Open

Address issues#90
pollytur wants to merge 15 commits intosensorium-competition:mainfrom
pollytur:address_issues

Conversation

@pollytur
Copy link
Contributor

Small PR to address issues #32 , #70 , #73

@gitnotebooks
Copy link

gitnotebooks bot commented Dec 12, 2025

Review these changes at https://app.gitnotebooks.com/sensorium-competition/experanto/pull/90

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issues #32, #70, and #73 by introducing a return_valid parameter to interpolation methods, removing unused code, and renaming a confusing transform option. The changes enable callers to optionally request validation masks from interpolation operations, making the API more flexible while maintaining backward compatibility through default parameter values.

Key Changes:

  • Added return_valid parameter to all interpolator classes to conditionally return validation masks
  • Renamed "standardize" transform mode to "normalize_variance_only" for clarity
  • Removed unused namedtuple imports and DataPoint class

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
experanto/interpolators.py Added return_valid parameter to abstract method and all concrete implementations (SequenceInterpolator, PhaseShiftedSequenceInterpolator, ScreenInterpolator, TimeIntervalInterpolator) with conditional return logic
experanto/experiment.py Updated interpolate method signature to accept and propagate return_valid parameter; removed unused namedtuple import
experanto/datasets.py Updated interpolate calls to use return_valid=False; renamed "standardize" to "normalize_variance_only"; removed unused namedtuple and DataPoint
configs/default.yaml Updated normalization config value from "standardize" to "normalize_variance_only"
docs/source/concepts/demo_configs.rst Updated example config to use "normalize_variance_only"
README.md Added documentation badge link

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pollytur and others added 3 commits February 27, 2026 12:27
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pollytur and others added 3 commits February 27, 2026 18:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pollytur
Copy link
Contributor Author

@reneburghardt @schewskone would be great if you could take a look
I also run pyright locally, so the type annotation should be actually fine. We could add it to the CI/CD later but I think this PR is big enough already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants