UIK-3013/date picker tests#2095
Merged
ilyabrower merged 21 commits intomasterfrom May 14, 2025
Merged
Conversation
ilyabrower
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is quite a complex component, so I divided the browser tests by component type:
Each browser test includes checks for roles and attributes, styles, input behavior, keyboard and mouse interactions, and props handling.
I also added more test stories to cover various states and props.
There are many snapshots, but they don’t duplicate each other — each snapshot focuses on different functionality (some check additional focus states, others check hover or specific props).
So despite the large number of tests, they provide good coverage of the component without redundancy and help prevent regressions.
I also added axe tests and removed almost all snapshots from unit tests, I left just a few to maintain some visual variability.
150 tests run ~2m
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile with planned publish date.