Add Cartan matrix computation for monoids#1048
Conversation
|
To update your branch to the latest
|
86d0dcf to
e7eb3e4
Compare
|
Try doing: |
ea50563 to
c70088b
Compare
james-d-mitchell
left a comment
james-d-mitchell
left a comment
There was a problem hiding this comment.
Thanks @JosephDayngerRuiz, this looks really great, there are a number of pretty minor things to fix, and then I'll be happy to merge.
james-d-mitchell
added
the
waiting-for-creator-input
reiniscirpons
left a comment
reiniscirpons
left a comment
There was a problem hiding this comment.
Hi Joey, thanks for the contribution! The code looks good, tests pass and doc renders well. I had some minor suggestions to improve the look of the docs and fix a dependency issue.
One other thing I would like to see before we merge would be some more tests for the functions you wrote. In particular, after running code coverage the following functions seem to lack tests:
GeneralizedConjugacyClassGeneralizedConjugacyClassesDClassBicharacter- The
ViewStringmethods forIsGeneralizedConjugacyClassandIsMonoidCharacter - The
DisplayStringmethods forIsMonoidCharacterTableandIsMonoidCartanMatrix LeftGreensMultiplierNCandRightGreensMultiplierNCwith filters[IsGroupAsSemigroup, IsMultiplicativeElement, IsMultiplicativeElement]
I see for some of these, like GeneralizedConjugacyClasses and DClassBicharacter you have tests in the docs, but for completeness I would also include them in the cartan.tst file as well. And the DisplayString methods should be tested too, since they seem to contain quite a bit of code.
If you want to run code coverage yourself, you should be able to do so by calling
./etc/code-coverage-test-gap.py --open --gap-root=../../ ./tst/standard/**/*.tst
from the semigroups package directory. You may need to change your gap root depending on where that is. After running the tests the script should give output like
SUCCESS!
See /tmp/tmpoa_xczdw/index.html
and open an html overview of the code coverage in your browser. If it does not automatically open the file in your browser, then you can open the specified html file from the script manually. The initial html page is an overview of coverage of all gap files, and navigating to the cartan.gi file will give a more detailed line-by-line coverage.
Once more tests are added, I think this looks good to merge. Thanks again :)
james-d-mitchell
left a comment
james-d-mitchell
left a comment
There was a problem hiding this comment.
Thanks @JosephDayngerRuiz, and apologies again for being slow to review this. Please make the changes indicated by @reiniscirpons and me, and then I'll be happy to merge. Also feel free to ping me if anything is unclear.
Typo correction related to semigroups#1048 (comment)
Typo correction related to semigroups#1048 (comment)
Introduces new attributes and methods for computing character tables and Cartan matrices of finite monoids, including documentation and tests. Adds GAPDoc documentation for new operations, updates bibliography, and integrates new attribute files into the package initialization and loading process.
1b4f178 to
ec915e4
Compare
Added tests for the display strings for the MonoidCharacterTable and MonoidCartanMatrix.
Missing new line in the test.
Describing a splitting field of a monoid.
Log to example test
Updated logs to examples try 2
Trying a different monoid
2fd4b45 to
dc61b9e
Compare
This reverts commit 56fe39e.
This reverts commit 1d44d05.
This reverts commit dc61b9e.
This reverts commit 271512c.
This reverts commit 70de81e.
Explanation for the log.
Testing an attribute reference.
Testing parentattr as a book reference.
Removing Attr
<Ref Attr="Parent" BookName = "ref"/> is the correct way to reference a parent attribute
Reworded for clarity
code spell issue
2ab2493 to
90c61a6
Compare
Put the gth roots into math mode.
gth roots are put into math mode
|
Thanks @JosephDayngerRuiz ! |
3 participants
This PR add several functions which allow for the computation of the character table of a monoid and the Cartan matraix of a monoid which satisfy IsActingSemigroups. The current implementation is close to the original implementation of Balthazar Charles.