Skip to content

Conversation

@vplasencia
Copy link
Member

Description

This PR updates the Semaphore version from 4.10.0 -> 4.13.0 after the bug fix in the Binary Merkle Root circuit.

Reference: semaphore-protocol/semaphore#999

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vplasencia vplasencia requested a review from a team as a code owner September 2, 2025 18:30
@vercel
Copy link

vercel bot commented Sep 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
semaphore-boilerplate Ready Ready Preview Comment Sep 2, 2025 6:30pm

@@ -1,7 +1,7 @@
NEXT_PUBLIC_DEFAULT_NETWORK=sepolia
NEXT_PUBLIC_INFURA_API_KEY=abf67af1010b4b8d877e04244f1eac3d

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to these changes and non-blocking, but is this a real api key in source control?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! This is just a test API key running client-side, which is why it starts with NEXT_PUBLIC. It's only for boilerplate/testing purposes, it's free with a limited number of calls. We've never had issues with this before, but if needed, we can set restrictions on the Infura side (e.g., limit it to a specific URL or contract).

@vplasencia vplasencia merged commit 41181f6 into main Sep 2, 2025
3 checks passed
@vplasencia vplasencia deleted the ref/update-semaphore-version branch September 2, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants