-
Notifications
You must be signed in to change notification settings - Fork 211
Release to Production - 2026-01-22 #1637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update build numbers and deployment timestamps after successful deployment. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Replace email support with Discord * Add Discord support prompts * Remove command log * formatting, agent feedback * update strings * save wip * fix button color * update text and change support from discord to notion support form * remove settings support form text * rename component and update feedback modal to redirect to users to notion form * formatting * update text
…ndroid handling (#1610) * Update edge-to-edge handling * update lock file * formatting * agent feedback
* feat: selfrica circuit and tests * chore: remove unused code * feat: test for ofac,date and olderthan * fix: public signal constant * feat: add contract tests * feat: helper function to gen TEE input * feat: gen circuit inputs with signature * feat: seralized base64 * fix: DateIsLessFullYear componenet * feat: register circuit for selfrica * feat: selfrica disclose circuit and test * fix: common module error * feat: add more test and fix constant * fix: commitment calculation * feat: selfrica contracts * test: selfrica register using unified circuit * feat: register persona and selfrica circuit * feat: selfrica circuit and tests * chore: remove unused code * feat: test for ofac,date and olderthan * fix: public signal constant * feat: add contract tests * feat: helper function to gen TEE input * feat: gen circuit inputs with signature * feat: seralized base64 * fix: DateIsLessFullYear componenet * feat: register circuit for selfrica * feat: selfrica disclose circuit and test * fix: common module error * feat: add more test and fix constant * fix: commitment calculation * feat: selfrica contracts * test: selfrica register using unified circuit * feat: register persona and selfrica circuit * refactor: contract size reduction for IdentityVerificationHubImplV2 export function logic to external libs, reduce compiler runs to 200, update deploy scripts to link new libs * feat: disclose circuit for persona * feat: update persona ofac trees * feat; register circuit for selfper * feat: disclose test for selfper * chore: refactor * chore : remove unused circuits * chore: rename selfper to kyc * chore: update comments * feat: constrain s to be 251 bit * feat: add range check on majority ASCII and comments * feat: range check on neg_r_inv * chore: remove is pk zero constrain * merge dev * feat: add registerPubkey function to Selfrica with GCPJWT Verification * test: add testing for GCPJWT verification on Selfrica * fix: script that calls register_selfrica circuits (ptau:14 -> ptau:15) * fix: get remaining Selfrica tests working with proper import paths * refactor: store pubkeys as string also add some comment code for registerPubkey function * refactor: remove registerPubkeyCommitment function some tests now skipped as awaiting changes to how pubkeys are stored (string instead of uint256) * feat: use hex decoding for the pubkey commitment * test: adjust tests for pubkey being string again * fix: remove old references to registerPubkey * docs: add full natspec for IdentityRegistrySelfricaImplV1 * docs: update files in rest of the repo for Selfrica attestation type * test: fix broken tests * fix: builds and move to kyc from selfrica * fix: constrain r_inv, Rx, s, T * feat: eddsa * feat: add onlyTEE check to registerPubkeyCommitment onlyOwner is able to change onlyTEE * refactor: update gcpRootCAPubkeyHash to be changeable by owner * feat: add events for update functions * style: move functions to be near other similar functions * fix: kyc happy flow * fix: all contract tests passing | fix: timestamp conversion with Date(), migrate to V2 for endToEnd test, scope formatting, fix register aadhaar issue by using block.timestamp instead of Date.now(), fix changed getter function name, enable MockGCPJWTVerifier with updated file paths, add missing LeanIMT import, fix user identifier format * audit: bind key offset-value offset and ensure image_digest only occurs once in the payload * fix: constrain bracket * chore: update comment * audit: hardcode attestation id * audit: make sure R and pubkey are on the curve * audit: ensure pubkey is within bounds * fix: all contract tests passing * feat: change max length to 99 from 74 * audit: don't check sha256 padding * audit: check the last window as well * audit: single occurance for eat_nonce and image_digest * audit: check if the certs are expired * audit: add the timestamp check to the contract * audit: make sure the person is less than 255 years of age * audit fixes * chore: yarn.lock * fix: build fixes * fix: aadhaar timestamp * lint * fix: types * format --------- Co-authored-by: vishal <[email protected]> Co-authored-by: Evi Nova <[email protected]>
* add keychain patch - wip * centralise useStrongbox flag usage * set allowBackup to false * bump to version 2.9.12 * bump android build for 2.9.12 * improve keychain error detection * Disable Strongbox by default --------- Co-authored-by: Justin Hernandez <[email protected]>
…e and info text (#1622) * Remove skip info text * prettier * fix test
* Refactor NFC scanner tests to use a global variable for platform OS, allowing dynamic switching between iOS and Android during tests. This change improves test isolation and avoids hoisting issues with jest.mock. * Triggering GitHub workflows * Add status animations and self logos * Update utilities and styles for statuses * Remove old LED implementation and occurences * Update Self QR Code with new design * Add status banner * Remove console and use QRcodeSteps in styles * Add ARIA and use Memo to prevent re-renders * Add refs for success and error callbacks * Use ref for self app in qrcode * Use selfapp ref consistently * Update connected state animtion * Skip 'parses Android response' test in nfcScanner --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Javier Cortejoso <[email protected]>
* fix mobile sdk tests * fix mobile sdk tests
Release to Staging - 2026-01-16
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
Release to Staging - 2026-01-22
Release to Staging - 2026-01-22
Update build numbers and deployment timestamps after successful deployment. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Include app version in release PR titles * agent feedback * agent feedback
…1628) * fix: implemented fix for skipped nfcScanner tests on ios and android * chore: yarn prettier
* format * pr feedback
* sumsub initial pass * add sumsub tee url * agent feedback and fixes * update lock * agent feedback * fix types * agnet feedback * fix mock * agent feedback * lazy load sumsub screen * white button color * fix lint * add debug url link * allow us to see recordings * debug maestro run * disable e2e screen recording for now. don't load sumsub logic when running e2e test * remove lazy loading * skip installing sumsub plugin * retest ios e2e * get e2e tests passing * clean up
* fix: circuits and contracts * feat: add reverse ofac logic * feat: add onlyRole modifiers to functions * style: replace onlyOwner reference in comment code to role-based access * test: unskip and update governance tests for access control * test: fix PCR0 setup in kyc test --------- Co-authored-by: Evi Nova <[email protected]>
* feat: add helper function to generate register circuit inputs * commit common
* feat(kyc): Other IDs button * trigger sumsub flow directly from event listener * formatting * formatting * add todo * add feature flag --------- Co-authored-by: Justin Hernandez <[email protected]>
Release to Staging - 2026-01-23
…sh lockfile (#1606) * Update dependency versions * Fix gesture handler Android dependency (#1611) * Patch screens codegen type (#1609) * Downgrade Sentry React Native (#1612) * fix patches and packages * downgrade versions for gesture handler and screens * agent feedback * fix ios building * allow ios tets to pass * formatting * make cache more resilient * Address CodeRabbitAI review comments This commit addresses all 7 unresolved CodeRabbitAI comments on PR #1606: Patch-package error handling (comments #1, #2, #3): - stderr capture already implemented in both root and workspace patch runs - Add CI warning when patches fail silently instead of exiting with 0 - Log completion status in CI mode for visibility Critical Mixpanel dependency fix (comment #5): - Add explicit Mixpanel-swift pod declaration to fix E2E build failures - Ensures Mixpanel is available even when NFCPassportReader is skipped during E2E testing React-native-web validation (comment #4): - Verified no usage of deprecated findNodeHandle, pointerEvents: 'box-none', or createPortal - Safe to upgrade from 0.19 to 0.21.2 CI workflow improvements (comments #6, #7): - Create cache-sdk-build composite action for consistent SDK build artifact caching - Replace all direct actions/cache@v4 usage with cache-yarn composite action - Replace all direct actions/cache/restore@v4 and save@v4 with cache-sdk-build - Add nested require() validation step before tests to fail fast on problematic patterns All changes follow repository coding guidelines for CI caching and test memory optimization. * Extend cache composite actions to all SDK workflows This commit extends the caching standardization from PR #1606 to include mobile-sdk-ci.yml and core-sdk-ci.yml workflows. New composite actions created: - cache-mobile-sdk-build: For mobile SDK build artifacts - cache-core-sdk-build: For core SDK build artifacts Workflow updates: - mobile-sdk-ci.yml: Replaced 5 instances of direct actions/cache with cache-mobile-sdk-build - core-sdk-ci.yml: Replaced 4 instances of direct actions/cache with cache-core-sdk-build All SDK CI workflows now use consistent caching patterns via composite actions, following the AGENTS.md guideline: "Use shared composite actions from .github/actions for CI caching instead of calling actions/cache directly." Benefits: - Consistent caching across all SDK workflows (qrcode, mobile, core) - Centralized cache configuration - easier to maintain - Follows established patterns from qrcode-sdk-ci.yml * downgrade react-native-svg * update pod lock file * sort
* integrate sumsub into error flows * formatting * fix test * format * clean up * udpate flows * agent feedback * updates * save wip updates * clean up design * updates * lint * agent feedback * formatting * fix
* fix typos * typo * match screen design. fix tests
chore: fix circuits tests in staging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| throw new Error( | ||
| 'Sumsub token expired - refresh not implemented for test flow', | ||
| ); | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sumsub token refresh throws error in production flow
Medium Severity
The launchSumsub function's token expiration handler throws an error when the Sumsub SDK access token expires, rather than refreshing it. This can crash the production KYC verification flow if a user's session is long or connection is slow. The handler's comment indicates it was intended for a test flow.
| | 'mrz_scan_failed' | ||
| | 'nfc_scan_failed' | ||
| | 'sumsub_initialization' | ||
| | 'sumsub_verification'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated FallbackErrorSource type definition
Low Severity
The FallbackErrorSource type is defined identically in two files: exported from useSumsubLauncher.ts and defined locally in RegistrationFallbackScreen.tsx. Both define the exact same union type with values 'mrz_scan_failed' | 'nfc_scan_failed' | 'sumsub_initialization' | 'sumsub_verification'. The exported version in useSumsubLauncher.ts is never imported anywhere, making the duplication unnecessary and increasing maintenance burden.
🎯 Production Release
Release Date: January 22, 2026
Commits ahead: 16
This automated PR promotes tested changes from
stagingtomainfor production deployment.What's Included
All changes that have been verified in the staging environment.
Note: This PR is directly from
staging, so new commits merged tostagingwill automatically appear here.Pre-Deployment Checklist
Deployment Notes
Merging this PR will trigger production deployment.
This PR was automatically created by the Release Calendar workflow on January 22, 2026
Note
Medium Risk
Medium risk: adds a new third-party KYC (Sumsub) flow plus new env/config paths and native dependency changes, which could impact onboarding and mobile builds; CI workflow changes may affect build reliability/caching behavior.
Overview
Adds Sumsub KYC as a new flow: introduces
@sumsub/react-native-mobilesdk-moduleintegration with token fetching fromSUMSUB_TEE_URL, a newkycdocument type handling inSelfClientProvider, and new screens/routes forRegistrationFallbackandKycSuccess.Improves developer/testing tooling: adds a dev-only error-injection store + UI, a dedicated
SumsubTestScreen, and E2E build controls (E2E_TESTING) to skip certain native deps while still compiling (e.g., Mixpanel), plus updated local E2E runner modes.Refactors support/feedback UX: replaces in-app feedback form/email flow with a support form link (
supportFormUrl) and simplifiesFeedbackModal; renamesFeedbackModalScreento a genericAlertModal.CI/workflow hardening and performance: adds composite cache actions for SDK builds, adds circuit build timeout and a new
register_kyccircuit build, improves Maestro caching/validation and rich diagnostics/artifacts, updates release PR titles to include app version, and adds minor dependency/build tweaks (Android ML Kit overrides, Sumsub maven repo, version bumps).Written by Cursor Bugbot for commit 2cc2951. This will update automatically on new commits. Configure here.