-
Notifications
You must be signed in to change notification settings - Fork 719
Add RawPacketBase
as common base class between raw packet implementations.
#1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1900 +/- ##
==========================================
- Coverage 82.89% 82.88% -0.01%
==========================================
Files 292 292
Lines 51834 51840 +6
Branches 11501 11316 -185
==========================================
+ Hits 42966 42967 +1
- Misses 7704 7710 +6
+ Partials 1164 1163 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Part of #1899
This PR adds a class
RawPacketBase
that is to work as a common base class betweenRawPacket
andMBufRawPacket
.The current iteration only takes over the management for
timestamp
andlinkLayer
as a minimal example, without defining common API yet.The class is defined in the
internal
namespace while in development, with the eventual goal to be "published" to the main namespace when complete.