-
Notifications
You must be signed in to change notification settings - Fork 380
Userpilot mobile destination #7800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Userpilot mobile destination #7800
Conversation
Hi @motasem-userpilot , Can you please clarify which Segment Integration this doc is for? Thank you , |
This documentation is for a Device-Mode Mobile Destination that supports iOS, Android, and React Native platforms. Thanks, |
Thanks @motasem-userpilot . Can you point to the source code for this Integration please? |
Thanks! You can find the source code here: iOS: https://github.com/Userpilot/segment-userpilot-ios |
Thanks for confirming @motasem-userpilot . Hi @stayseesong I'm not the correct technical resource to review this PR. I recommend asking someone from the Mobile SDK team to look at it. I only work with Web and Cloud Mode Integrations. |
LGTM! Nicely done plugin. |
Thanks for looking at this @bsneed ! |
@bsneed @joe-ayoub-segment is there a destination ID that needs to accompany this mobile destination? Normally for all of our other destinations that get added onto the docs site, there's a destination ID that needs to be added in. |
Not sure on that. I see some Userpilot entries in the destination list in the app, but not familiar with the ID aspect. |
Hi @stayseesong I don't know. I've not ever contributed to any mobile work. |
Hi @joe-ayoub-segment and Team, I believe the ID will be available once the destination is approved. We have created a new destination using the Segment developer dashboard (Userpilot Mobile), which is currently under review. Based on a previous conversation with the partnership team, they advised us to self-host our plugins for mobile and create a destination entry to manage the integration. |
Hi @ThabetIbrahim ! Best regards, |
No problem @joe-ayoub-segment! Happy to help. |
@joe-ayoub-segment am I good to merge this in or do I need to wait for anything else? |
Co-authored-by: stayseesong <[email protected]>
Proposed changes
Adding documentation for Segment x Userpilot mobile integration
Merge timing
ASAP