Skip to content

Conversation

joe-ayoub-segment
Copy link
Contributor

TikTok Conversions Destination

  • Adding CRM support
  • Adding vehicle fields support
  • Adding travel fields support

Testing

Needs end to end testing
Needs unit tests

Copy link

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 36.13445% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.48%. Comparing base (eaa9a86) to head (e9c4e08).

Files with missing lines Patch % Lines
...nations/tiktok-conversions/reportWebEvent/utils.ts 25.49% 48 Missing and 28 partials ⚠️

❌ Your patch check has failed because the patch coverage (36.13%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
- Coverage   79.69%   79.48%   -0.22%     
==========================================
  Files        1154     1157       +3     
  Lines       21266    21316      +50     
  Branches     4102     4147      +45     
==========================================
- Hits        16949    16943       -6     
- Misses       3615     3653      +38     
- Partials      702      720      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Aug 7, 2025

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Tiktok Conversions, Action Field(s):lead_fields

Add these new fields as optional instead and assume default values in perform or performBatch block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant