make os.walk return unicode strings#18
Open
petergx wants to merge 1 commit intoseedifferently:masterfrom
petergx:master
Open
make os.walk return unicode strings#18petergx wants to merge 1 commit intoseedifferently:masterfrom petergx:master
petergx wants to merge 1 commit intoseedifferently:masterfrom
petergx:master
Conversation
s3 keys are in unicode, and our local paths need to be for same-file comparisons.
|
hmm I see that this is probably a better fix than the one in my pull request #21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s3 keys are in unicode, and our local paths need to be for same-file
comparisons.