Skip to content

Conversation

ralphbean
Copy link

@ralphbean ralphbean commented Sep 18, 2025

User description

For https://issues.redhat.com/browse/KONFLUX-6210, clair needs access to a name and cpe label that it can use to look up the image in VEX statements.

See also release-engineering/rhtap-ec-policy#149

Signed-off-by: Ralph Bean [email protected]
Assisted-by: Gemini


PR Type

Other


Description

  • Update container image name and CPE labels

  • Add CPE identifier for VEX statement lookup


Diagram Walkthrough

flowchart LR
  A["Dockerfile.rhtas-operator.rh"] --> B["Updated name label"]
  A --> C["Added CPE label"]
  B --> D["VEX statement lookup"]
  C --> D
Loading

File Walkthrough

Relevant files
Configuration changes
Dockerfile.rhtas-operator.rh
Update container labels for VEX compatibility                       

Dockerfile.rhtas-operator.rh

  • Updated name label from rhtas-operator to rhtas/rhtas-rhel9-operator
  • Added new cpe label with value
    cpe:/a:redhat:trusted_artifact_signer:1.2::el9
+2/-1     

Summary by Sourcery

Update container image metadata to include accurate name and CPE labels for vulnerability scanning

Build:

  • Set name label to rhtas/rhtas-rhel9-operator
  • Add CPE label cpe:/a:redhat:trusted_artifact_signer:1.2::el9 for VEX statement lookup

…r-v1-2

For https://issues.redhat.com/browse/KONFLUX-6210, clair needs access to a name and cpe label that it can use to look up the image in VEX statements.

See also release-engineering/rhtap-ec-policy#149

Signed-off-by: Ralph Bean <[email protected]>
Assisted-by: Gemini
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Label Consistency

Verify the new name value aligns with repository/image naming conventions used elsewhere (including tag automation, build/push, and downstream references) to avoid breaking tooling that relies on the previous name.

LABEL name="rhtas/rhtas-rhel9-operator"
LABEL cpe="cpe:/a:redhat:trusted_artifact_signer:1.2::el9"
CPE Format/Accuracy

Validate that the cpe value matches the expected CPE URI format and correct product/version mapping used by Clair/VEX pipelines; confirm :1.2::el9 is the intended target and won’t miss matches.

LABEL cpe="cpe:/a:redhat:trusted_artifact_signer:1.2::el9"

Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Update CPE string to modern format

Update the CPE string from the deprecated cpe:/ (version 2.2) format to the
current cpe:2.3: format to ensure compatibility with modern tooling.

Dockerfile.rhtas-operator.rh [43]

-LABEL cpe="cpe:/a:redhat:trusted_artifact_signer:1.2::el9"
+LABEL cpe="cpe:2.3:a:redhat:trusted_artifact_signer:1.2:*:*:*:*:el9:*:*"
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies that the cpe label uses a deprecated format and proposes updating it to the current standard, which improves compatibility with modern security scanners.

Medium
  • More

Copy link

sourcery-ai bot commented Sep 18, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

PR updates container image metadata in Dockerfile.rhtas-operator.rh to support VEX lookups by modifying the name label and adding a CPE identifier.

File-Level Changes

Change Details Files
Container image labels updated for VEX compatibility
  • Updated name label to "rhtas/rhtas-rhel9-operator"
  • Added cpe label "cpe:/a:redhat:trusted_artifact_signer:1.2::el9"
Dockerfile.rhtas-operator.rh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@osmman
Copy link
Collaborator

osmman commented Sep 22, 2025

/ok-to-test

@osmman osmman merged commit 6424925 into securesign:release-1.2 Sep 23, 2025
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants