Skip to content

Pipeline Update #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release-1.1
Choose a base branch
from
Open

Pipeline Update #1204

wants to merge 3 commits into from

Conversation

tommyd450
Copy link
Contributor

@tommyd450 tommyd450 commented Jul 21, 2025

Summary by Sourcery

Refactor rhtas-operator bundle PipelineRuns to use a shared external pipelineRef, update triggers to the main branch, and streamline configuration.

Enhancements:

  • Replace inline pipelineSpec blocks with a pipelineRef pointing to a shared OCI-based bundle-build pipeline in an external Git repository
  • Update pipelinesascode on-cel-expression triggers to target the main branch and broaden path change filters
  • Standardize metadata labels and image naming conventions for both pull-request and push PipelineRuns
  • Consolidate and reorder parameters including prefetch-input JSON, image-expires-after, manager selector, and registry URL
  • Add build-nudge-files annotation and specify a serviceAccountName via taskRunTemplate

Copy link

sourcery-ai bot commented Jul 21, 2025

Reviewer's Guide

This PR refactors both pull-request and push Tekton PipelineRuns by updating branch triggers to main with broader path patterns, normalizing metadata labels, extracting inline specs into a centralized pipelineRef, and overhauling parameters including new manager selectors and service account configuration.

File-Level Changes

Change Details Files
Trigger expressions and metadata labels updated
  • Changed pipelinesascode.on-cel-expression to trigger on main branch
  • Expanded pathChanged patterns to include config/, hack/, api/, internal/, cmd/, test/, go.mod, go.sum, and additional Dockerfiles
  • Normalized appstudio.openshift.io/application and component labels by removing version suffix
  • Added build-nudge-files annotation in push PipelineRun
.tekton/rhtas-operator-bundle-pull-request.yaml
.tekton/rhtas-operator-bundle-push.yaml
Parameter list overhauled and image tag naming simplified
  • Reordered and consolidated params: moved revision, dockerfile, hermetic, prefetch-input, image-expires-after
  • Removed legacy params (build-image-index, skip-checks, go_test_command etc.)
  • Added manager-pipelinerun-selector and manager-registry-url params
  • Updated output-image values to remove -v1-1 suffix
.tekton/rhtas-operator-bundle-pull-request.yaml
.tekton/rhtas-operator-bundle-push.yaml
Inline pipelineSpec replaced with external pipelineRef
  • Removed embedded pipelineSpec sections including tasks and finally steps
  • Introduced pipelineRef pointing to https://github.com/securesign/pipelines.git at pipelines/bundle-build-oci-ta.yaml
  • Switched resolver to git and set pathInRepo
.tekton/rhtas-operator-bundle-pull-request.yaml
.tekton/rhtas-operator-bundle-push.yaml
Workspace and service account configuration simplified
  • Removed volumeClaimTemplate-based workspace definition
  • Added serviceAccountName under taskRunTemplate
.tekton/rhtas-operator-bundle-pull-request.yaml
.tekton/rhtas-operator-bundle-push.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
operator-v1-0 no kind "ProjectDevelopmentStream" is registered for version "projctl.konflux.dev/v1beta1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"
operator-v1-1 no kind "ProjectDevelopmentStream" is registered for version "projctl.konflux.dev/v1beta1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"
operator no kind "Project" is registered for version "projctl.konflux.dev/v1beta1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"
operator-template no kind "ProjectDevelopmentStreamTemplate" is registered for version "projctl.konflux.dev/v1beta1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"

Copy link
Collaborator

@osmman osmman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release-1.1 and Release-1.2 branches will not work with Konflux pipelines for building bundle images from the securesign/pipelines repository. This is due to significant refactoring of the bundle source code and build process on the main branch, making them incompatible without extensive rework.

https://issues.redhat.com/browse/SECURESIGN-2463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants