Async Backup support #134

MagicFun1241 · 2025-07-21T13:58:59Z

This PR adds ability to deploy weed in "filer.backup" mode.

What changed?

bumped go version to 1.24
bumped seaweed version
added access to secrets and persistentvolumeclaims resources in manager-role
added support of taking credentials from secrets with optional fields mapping
sink option supports all providers and fields that were in scaffold
refactored to propagate context in more places

Example:

apiVersion: seaweed.seaweedfs.com/v1
kind: Seaweed
metadata:
  name: seaweed
spec:
  image: chrislusf/seaweedfs:latest
  volumeServerDiskCount: 1
  hostSuffix: seaweed.abcdefg.com
  master:
    replicas: 1
    volumeSizeLimitMB: 1024
  volume:
    replicas: 1
    requests:
      storage: 2Gi
  filerBackup:
    replicas: 1
    sink:
      s3:
        enabled: true
        awsCredentialsSecretRef:
          name: backup-credentials
          mapping:
            awsSecretAccessKey: secretKey
            awsAccessKeyID: accessKey
  filer:
    replicas: 1
    config: |
      [leveldb2]
      enabled = true
      dir = "/data/filerldb2"

Tests

Tested sink.local backup in local cluster, tested secret getting for configmap

…to Go 1.24

…eed_v1_seaweed_with_backup.yaml

…et references to seaweed types and update deepcopy functions

…erator

gemini-code-assist

Summary of Changes

Hello @MagicFun1241, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the SeaweedFS Operator by introducing a dedicated Filer Backup component. This new feature allows users to configure and manage asynchronous backups of their filer data to a variety of destinations, including local storage, other filers, and popular cloud storage services. The implementation includes robust credential management via Kubernetes secrets and integrates seamlessly with the existing operator framework.

Highlights

New Filer Backup Component: Introduced a new FilerBackup component within the Seaweed custom resource, enabling asynchronous backup capabilities for SeaweedFS filer data.
Flexible Backup Sink Configurations: Added comprehensive support for various backup destinations, including local file systems, filer-to-filer replication, and major cloud storage providers like AWS S3, Google Cloud Storage, Azure Blob Storage, and Backblaze B2.
Secure Credential Management: Implemented a mechanism to securely fetch cloud storage credentials from Kubernetes secrets, allowing for flexible key mapping to adapt to different secret structures.
Kubernetes Operator Integration: Extended the operator's reconciliation logic, RBAC roles, and Helm chart to properly manage the lifecycle of the new Filer Backup component, including its ConfigMap and StatefulSet.
Dependency and Toolchain Updates: Upgraded the Go toolchain to version 1.24 and updated numerous Go module dependencies, including the core seaweedfs library and various cloud SDKs, ensuring compatibility and leveraging newer features.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces support for asynchronous filer backups to various storage sinks. The changes include new API types for backup configuration, RBAC updates for accessing secrets and PVCs, and the controller logic to manage backup statefulsets and configmaps.

My review focuses on improving robustness, maintainability, and configuration correctness.

deploy/helm/values.yaml

internal/controller/controller_filer_backup_configmap.go

config/samples/seaweed_v1_seaweed_all_sinks.yaml

internal/controller/controller_filer_backup_configmap.go

gemini-code-assist · 2025-07-21T14:01:46Z

internal/controller/controller_filer_backup_statefulset.go

+func buildStubProbeHandler() corev1.ProbeHandler {
+	return corev1.ProbeHandler{
+		Exec: &corev1.ExecAction{
+			Command: []string{
+				"/bin/sh",
+				"-c",
+				"echo OK",
+			},
+		},
+	}


The buildStubProbeHandler function creates readiness and liveness probes that use a stub command (echo OK). This means the pod will always be considered healthy even if the weed filer.backup process has crashed or is not functioning correctly.

Please consider implementing a more meaningful health check.

As far as I noticed, filer.backup doesn't provides a place for health checking. Its don't listens HTTP/GRPC/Metrics port

…e claims and secrets in role configuration

…sinks.yaml

… Google Cloud Storage, and refactor existing sink configuration logic

MagicFun1241 · 2025-07-21T14:29:20Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces asynchronous backup capabilities for the SeaweedFS filer. The changes include new API types for configuring backups to various sinks, RBAC updates, and controller logic. The review focuses on improving security by addressing credential storage, robustness by enhancing secret handling, and correctness by fixing configuration issues and improving health probes.

gemini-code-assist · 2025-07-21T14:31:31Z

api/v1/seaweed_types.go

+	AWSAccessKeyID string `json:"awsAccessKeyID,omitempty"`
+
+	// AWS secret access key (if empty, loads from shared credentials file)
+	AWSSecretAccessKey string `json:"awsSecretAccessKey,omitempty"`


Storing credentials like AWSAccessKeyID and AWSSecretAccessKey directly in the CRD poses a security risk, as they are stored in etcd in plain text. It's safer to use awsCredentialsSecretRef to fetch them from a Kubernetes Secret. Consider deprecating these fields and adding a warning in the field documentation.

Suggested change

AWSAccessKeyID string `json:"awsAccessKeyID,omitempty"`

// AWS secret access key (if empty, loads from shared credentials file)

AWSSecretAccessKey string `json:"awsSecretAccessKey,omitempty"`

// AWS access key ID (DEPRECATED: Use awsCredentialsSecretRef instead for better security)

AWSAccessKeyID string `json:"awsAccessKeyID,omitempty"`

// AWS secret access key (DEPRECATED: Use awsCredentialsSecretRef instead for better security)

AWSSecretAccessKey string `json:"awsSecretAccessKey,omitempty"`

config/samples/seaweed_v1_seaweed_all_sinks.yaml

internal/controller/backup/s3_sink.go

config/samples/seaweed_v1_seaweed_all_sinks.yaml

config/samples/seaweed_v1_seaweed_with_backup.yaml

gemini-code-assist · 2025-07-21T14:31:32Z

internal/controller/controller_filer_backup_statefulset.go

+		ReadinessProbe: &corev1.Probe{
+			ProbeHandler:        buildStubProbeHandler(),
+			InitialDelaySeconds: 10,
+			TimeoutSeconds:      3,
+			PeriodSeconds:       15,
+			SuccessThreshold:    1,
+			FailureThreshold:    100,
+		},
+		LivenessProbe: &corev1.Probe{
+			ProbeHandler:        buildStubProbeHandler(),
+			InitialDelaySeconds: 20,
+			TimeoutSeconds:      3,
+			PeriodSeconds:       30,
+			SuccessThreshold:    1,
+			FailureThreshold:    6,
+		},
+	}}


The readiness and liveness probes use echo OK, verifying only the container's shell. Implement more meaningful probes using a health check endpoint (e.g., an HTTP endpoint or a metrics port) exposed by the filer.backup process to improve deployment reliability.

…iguration

… for Azure, Backblaze, GCS, and S3 sinks

MagicFun1241 · 2025-07-21T14:44:47Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces the ability to deploy weed in "filer.backup" mode, adding support for asynchronous backups to various cloud storage providers. The API changes are well-structured.

internal/controller/backup/azure_sink.go

internal/controller/backup/backblaze_sink.go

internal/controller/backup/gcs_sink.go

internal/controller/backup/s3_sink.go

gemini-code-assist · 2025-07-21T14:46:37Z

internal/controller/controller_filer_backup_statefulset.go

+		ReadinessProbe: &corev1.Probe{
+			ProbeHandler:        buildStubProbeHandler(),
+			InitialDelaySeconds: 10,
+			TimeoutSeconds:      3,
+			PeriodSeconds:       15,
+			SuccessThreshold:    1,
+			FailureThreshold:    100,
+		},
+		LivenessProbe: &corev1.Probe{
+			ProbeHandler:        buildStubProbeHandler(),
+			InitialDelaySeconds: 20,
+			TimeoutSeconds:      3,
+			PeriodSeconds:       30,
+			SuccessThreshold:    1,
+			FailureThreshold:    6,
+		},


The readiness and liveness probes use a stub command (echo OK), confirming only the pod's shell responsiveness, not the weed filer.backup process's health. A long-running backup job could be stuck or failed without detection.

Investigate a more robust health check mechanism, like an HTTP endpoint or a command to check its status.

…GCS, and S3 credential extraction

MagicFun1241 · 2025-07-21T14:50:39Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces asynchronous backup support for SeaweedFS filers. I've provided feedback focusing on improving security by removing plaintext credentials from the CRD and tightening RBAC permissions. I also suggest enhancing the robustness of the backup pods with more meaningful health probes and fixing a bug in the credential extraction logic. Overall, this is a great feature, and with these changes, it will be even more secure and reliable.

gemini-code-assist · 2025-07-21T14:52:16Z

api/v1/seaweed_types.go

+	// AWS access key ID (if empty, loads from shared credentials file)
+	AWSAccessKeyID string `json:"awsAccessKeyID,omitempty"`
+
+	// AWS secret access key (if empty, loads from shared credentials file)
+	AWSSecretAccessKey string `json:"awsSecretAccessKey,omitempty"`


Storing credentials like AWSAccessKeyID and AWSSecretAccessKey directly in the CRD spec poses a security risk, as they are stored in plaintext in etcd. It's recommended to only support sourcing these from Kubernetes secrets. This concern applies to other sink configurations that handle sensitive credentials, such as AzureSinkConfig and BackblazeSinkConfig. Consider removing these fields and relying solely on the ...CredentialsSecretRef fields.

gemini-code-assist · 2025-07-21T14:52:16Z

internal/controller/backup/backblaze_sink.go

+			if masterKey, exists := secret[mapping.B2MasterApplicationKey]; exists {
+				b2MasterApplicationKey = masterKey
+			}


There are a couple of issues here with fetching the Backblaze master application key:

Bug: If mapping.B2MasterApplicationKey is empty, the code will try to look up an empty string key in the secret data (secret[""]), which is likely not the intended behavior. A default key name should be used, similar to how b2AccountIDKey is handled.

Inconsistent Logging: There is no log message if a custom-mapped B2MasterApplicationKey is not found in the secret, which is inconsistent with the handling of b2AccountID and other credential extraction logic in this PR.

b2MasterApplicationKeyName := mapping.B2MasterApplicationKey if b2MasterApplicationKeyName == "" { b2MasterApplicationKeyName = "b2MasterApplicationKey" } if masterKey, exists := secret[b2MasterApplicationKeyName]; exists { b2MasterApplicationKey = masterKey } else if mapping.B2MasterApplicationKey != "" { log.Info("Secret key not found in secret", "secret", backblazeConfig.BackblazeCredentialsSecretRef.Name, "mapping", b2MasterApplicationKeyName) }

gemini-code-assist · 2025-07-21T14:52:17Z

internal/controller/controller_filer_backup_statefulset.go

+func buildStubProbeHandler() corev1.ProbeHandler {
+	return corev1.ProbeHandler{
+		Exec: &corev1.ExecAction{
+			Command: []string{
+				"/bin/sh",
+				"-c",
+				"echo OK",
+			},
+		},
+	}


The readiness and liveness probes are using a stub echo OK command. This is not a meaningful health check. It only verifies that the shell is available in the container, not that the filer.backup process is running and healthy. This could lead to a situation where the backup process has crashed or is stuck, but the pod is still considered healthy, causing silent backup failures.

Please implement a more robust health check. If weed filer.backup does not provide a health check endpoint, consider alternatives like:

Checking if the weed process is running (pgrep weed).

Having the process touch a file periodically and checking the file's modification time.

gemini-code-assist · 2025-07-21T14:52:17Z

internal/controller/seaweed_controller.go

 // +kubebuilder:rbac:groups=extensions,resources=ingresses,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=networking.k8s.io,resources=ingresses,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=core,resources=pods,verbs=get;list;
+// +kubebuilder:rbac:groups=core,resources=secrets,verbs=get;list;


The ClusterRole is granted list permission on secrets cluster-wide. This is a security risk as it violates the principle of least privilege. The controller logic in getSecret only ever fetches a specific secret by name and namespace using r.Get(), so get permission is sufficient. The list permission does not appear to be used and should be removed to reduce the operator's potential attack surface.

Suggested change

// +kubebuilder:rbac:groups=core,resources=secrets,verbs=get;list;

// +kubebuilder:rbac:groups=core,resources=secrets,verbs=get;

gemini-code-assist · 2025-07-21T14:52:17Z

internal/controller/backup/azure_sink.go

+			} else {
+				log.Info("Secret key not found in secret", "secret", azureConfig.AzureCredentialsSecretRef.Name, "mapping", accountNameKey)
+			}


The logging for a missing secret key is inconsistent with other sinks like S3. Here, it logs an info message even if no custom mapping was provided and the default key is not found. Other sinks only log if a custom mapping was provided but the key was not found in the secret. For consistency, this should be changed.

Suggested change

} else {

log.Info("Secret key not found in secret", "secret", azureConfig.AzureCredentialsSecretRef.Name, "mapping", accountNameKey)

}

} else if mapping.AccountName != "" {

log.Info("Secret key not found in secret", "secret", azureConfig.AzureCredentialsSecretRef.Name, "mapping", accountNameKey)

}

gemini-code-assist · 2025-07-21T14:52:17Z

internal/controller/backup/azure_sink.go

+			} else {
+				log.Info("Secret key not found in secret", "secret", azureConfig.AzureCredentialsSecretRef.Name, "mapping", accountKeyKey)
+			}


Similar to the AccountName field, the logging for a missing AccountKey is inconsistent with other sinks. It should only log if a custom mapping was provided but the key was not found.

Suggested change

} else {

log.Info("Secret key not found in secret", "secret", azureConfig.AzureCredentialsSecretRef.Name, "mapping", accountKeyKey)

}

} else if mapping.AccountKey != "" {

log.Info("Secret key not found in secret", "secret", azureConfig.AzureCredentialsSecretRef.Name, "mapping", accountKeyKey)

}

gemini-code-assist · 2025-07-21T14:52:17Z

internal/controller/controller_filer_backup_statefulset.go

+			TimeoutSeconds:      3,
+			PeriodSeconds:       15,
+			SuccessThreshold:    1,
+			FailureThreshold:    100,


The FailureThreshold for the readiness probe is set to 100. With a PeriodSeconds of 15, this means the pod can fail readiness checks for up to 25 minutes (100 * 15s) before being marked as Unready. This seems excessively high and could mask startup problems for a long time. A lower value, e.g., 20, would be more appropriate to detect issues faster.

Suggested change

FailureThreshold: 100,

FailureThreshold: 20,

…s in backup sink

… StatefulSet

…xtraction

MagicFun1241 · 2025-07-21T15:10:38Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces asynchronous backup support. The changes include adding access to secrets and persistentvolumeclaims resources, supporting credentials from secrets, and enabling sink options for various providers. The code is well-structured, but there are some areas for improvement, including health probes, context propagation, and dependency management.

gemini-code-assist · 2025-07-21T15:11:55Z

internal/controller/controller_filer_backup_statefulset.go

+		ReadinessProbe: &corev1.Probe{
+			ProbeHandler:        buildStubProbeHandler(),
+			InitialDelaySeconds: 10,
+			TimeoutSeconds:      3,
+			PeriodSeconds:       15,
+			SuccessThreshold:    1,
+			FailureThreshold:    20,
+		},
+		LivenessProbe: &corev1.Probe{
+			ProbeHandler:        buildStubProbeHandler(),
+			InitialDelaySeconds: 20,
+			TimeoutSeconds:      3,
+			PeriodSeconds:       30,
+			SuccessThreshold:    1,
+			FailureThreshold:    6,
+		},


The readiness and liveness probes for the filer-backup container are using a stub echo OK command. This is a critical correctness issue, as it means the pod will always be reported as healthy to Kubernetes, even if the filer.backup process has crashed, hung, or is failing to perform backups. This can lead to a non-functional backup system that appears to be working correctly.

A proper health check must be implemented. Please investigate if the weed filer.backup command provides a health check endpoint or mechanism that can be used. If not, a more robust check should be devised, for example:

Checking for the existence and recent modification of a status file.

Executing a command that verifies the weed process is running and responsive.

gemini-code-assist · 2025-07-21T15:11:55Z

config/rbac/role.yaml

+- apiGroups:
+  - ""
+  resources:
+  - persistentvolumeclaims
+  verbs:
+  - create
+  - delete
+  - get
+  - list
+  - patch
+  - update
+  - watch


These permissions grant access to create, delete, get, list, patch, update, and watch persistentvolumeclaims. While necessary for managing the backup process, ensure that these permissions are scoped appropriately to prevent unintended modifications to other PVCs in the cluster. Consider using more restrictive resource names or labels if possible.

internal/controller/swadmin/seaweed_admin.go

gemini-code-assist · 2025-07-21T15:11:55Z

go.mod

-	github.com/spf13/pflag v1.0.5 // indirect
-	github.com/spf13/viper v1.13.0 // indirect
-	github.com/subosito/gotenv v1.4.1 // indirect
+	github.com/seaweedfs/seaweedfs v0.0.0-20250625060439-95261a712ee2


Consider using a more specific version or a version range instead of a wildcard version for github.com/seaweedfs/seaweedfs to ensure consistent and reproducible builds. This can prevent unexpected issues caused by breaking changes in future versions of the dependency.

…rt resolution in controllers

…ons in seaweed_webhook.go, and refactor admin service and stateful set management in controller_admin.go

… set for improved gRPC support

…address configuration for service monitoring

…installation and usage instructions for SeaweedFS Operator

…les, enhancing accessibility and clarity

…ks, improving consistency and readability

…ols version to v0.18.0, and enhance CRD definitions with bucketclaims support and RBAC permissions

…g for better debugging

…to streamline cross-compilation process

…guration in Seaweed controller

…configurations, update Dockerfile and go.mod for improved build process

…reateS3BucketWithObjectLock function

…ithQuota to utilize CreateS3BucketWithObjectLock for improved bucket creation logic

…creation and reconciliation logic

…in admin server

…tClaim controller

…stom config is provided

…c filer client configuration

…to improve logging granularity

…for better readability and maintainability

…es.yaml

chrislusf · 2025-07-28T19:35:56Z

thanks for the big effort. Is it done and ready for review?

…figuration in deployment and service templates for seaweedfs-operator

…ted webhook templates for seaweedfs-operator

MagicFun1241 added 7 commits June 25, 2025 16:48

feat: add filerBackup to crd basing on filer

2b337ec

chore: update Go version and dependencies, upgrade Docker base image …

376a7db

…to Go 1.24

feat: filer backups supports

f01842f

refactor: remove unused S3 backup and service configuration from seaw…

d99c71e

…eed_v1_seaweed_with_backup.yaml

feat: add Azure, Google Cloud Storage, and Backblaze credentials secr…

5ef80cb

…et references to seaweed types and update deepcopy functions

Merge branch 'master' of https://github.com/MagicFun1241/seaweedfs-op…

83390b2

…erator

fix(revert): cgo for controller-gen

1bb68cd

gemini-code-assist bot reviewed Jul 21, 2025

View reviewed changes

feat: enhance RBAC permissions by adding support for persistent volum…

4cb742c

…e claims and secrets in role configuration

MagicFun1241 force-pushed the master branch from fcf7df3 to 4cb742c Compare July 21, 2025 14:07

MagicFun1241 added 3 commits July 21, 2025 17:14

refactor: remove S3 backup configuration from seaweed_v1_seaweed_all_…

32186ad

…sinks.yaml

chore: implement backup sink configurations for Azure, Backblaze, and…

b5b0a1a

… Google Cloud Storage, and refactor existing sink configuration logic

refactor: update context handling in filer backup configuration methods

aa85a8f

gemini-code-assist bot reviewed Jul 21, 2025

View reviewed changes

MagicFun1241 added 3 commits July 21, 2025 17:34

chore: fix newline at end of file in backup configuration samples

8b8a417

chore: remove metricsPort from seaweed_v1_seaweed_all_sinks.yaml conf…

e34b11a

…iguration

refactor: improve secret key handling in backup credential extraction…

d4af7e6

… for Azure, Backblaze, GCS, and S3 sinks

gemini-code-assist bot reviewed Jul 21, 2025

View reviewed changes

refactor: streamline secret key retrieval logic in Azure, Backblaze, …

05c6c21

…GCS, and S3 credential extraction

gemini-code-assist bot reviewed Jul 21, 2025

View reviewed changes

MagicFun1241 added 4 commits July 21, 2025 17:56

refactor: enhance secret key retrieval logic for Backblaze credential…

2d93c27

…s in backup sink

refactor: adjust failure threshold for liveness probe in Filer backup…

66724a9

… StatefulSet

refactor: update RBAC permissions for secrets in Seaweed controller

9a6ff51

refactor: unify secret key retrieval logic in GCS and S3 credential e…

398c666

…xtraction

gemini-code-assist bot reviewed Jul 21, 2025

View reviewed changes

MagicFun1241 added 27 commits July 23, 2025 22:45

feat: add RBAC permissions for ServiceMonitors and enhance metrics po…

9700add

…rt resolution in controllers

chore: update dependencies in go.mod and go.sum, enhance CRD definiti…

61d33a7

…ons in seaweed_webhook.go, and refactor admin service and stateful set management in controller_admin.go

feat: add admin-grpc port configuration to admin service and stateful…

1f8c55d

… set for improved gRPC support

chore: bump seaweedfs-operator version to 1.2.0 and add metrics-bind-…

db6b207

…address configuration for service monitoring

docs: update README.md to improve clarity, fix typos, and streamline …

1fbfce3

…installation and usage instructions for SeaweedFS Operator

docs: update README.md to include absolute links for guides and examp…

5f21340

…les, enhancing accessibility and clarity

docs: update README.md to remove unnecessary file extensions from lin…

2477679

…ks, improving consistency and readability

feat: bucket claim

de67d25

chore: update seaweedfs-operator to version 1.3.0, bump controller-to…

63ebc58

…ols version to v0.18.0, and enhance CRD definitions with bucketclaims support and RBAC permissions

refactor: update bucket claim reconciliation logic and enhance loggin…

cbc2267

…g for better debugging

chore: remove Darwin build targets from Makefile and Docker workflow …

532ad1b

…to streamline cross-compilation process

refactor: enhance volume request validation and default storage confi…

8d72b5f

…guration in Seaweed controller

feat: enhance bucket claim specifications with object lock and quota …

1956b1c

…configurations, update Dockerfile and go.mod for improved build process

feat: add validation for bucket name length and object lock mode in C…

d76f041

…reateS3BucketWithObjectLock function

feat: implement quota conversion utility and refactor CreateS3BucketW…

c99f174

…ithQuota to utilize CreateS3BucketWithObjectLock for improved bucket creation logic

refactor: use zap

4d95fa1

feat: add S3 credentials management to BucketClaim, including secret …

88e9df6

…creation and reconciliation logic

feat: add credential management and user structures for object store …

7fa235d

…in admin server

feat: implement S3 user deletion and enhance user management in Bucke…

4ab899a

…tClaim controller

refactor: remove generateS3Credentials function

0856762

feat: add default LevelDB configuration to Filer ConfigMap when no cu…

2f4ef64

…stom config is provided

feat: enhance credential management in admin server to support dynami…

1515406

…c filer client configuration

refactor: change log level from Info to Debug for various components …

e1a5c79

…to improve logging granularity

refactor: extract username formatting logic into a separate function …

6a541c6

…for better readability and maintainability

chore: bump version to 1.3.1 in Chart.yaml for seaweedfs-operator

10c5f59

fix: update image registry and version for seaweedfs-operator in valu…

4da1b34

…es.yaml

chore: bump version to 1.3.2 in Chart.yaml for seaweedfs-operator

2e4b4fb

MagicFun1241 added 2 commits August 2, 2025 00:22

chore: bump version to 1.3.3 in Chart.yaml and add webhook server con…

3d6384e

…figuration in deployment and service templates for seaweedfs-operator

feat: introduce S3 configuration support in FilerSpec and update rela…

79a1a07

…ted webhook templates for seaweedfs-operator

	// +kubebuilder:rbac:groups=core,resources=secrets,verbs=get;list;
	// +kubebuilder:rbac:groups=core,resources=secrets,verbs=get;

Async Backup support #134

Are you sure you want to change the base?

Async Backup support #134

Uh oh!

Conversation

MagicFun1241 commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

MagicFun1241 Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MagicFun1241 commented Jul 21, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

MagicFun1241 commented Jul 21, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

MagicFun1241 commented Jul 21, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 21, 2025

Choose a reason for hiding this comment

MagicFun1241 commented Jul 21, 2025 •

edited

Loading

MagicFun1241 Jul 21, 2025 •

edited

Loading