Skip to content

Add error message when fitting with empty metadata #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2025

Conversation

fealho
Copy link
Member

@fealho fealho commented Jul 29, 2025

CU-86b54q0kz, Resolve #2553.

@sdv-team
Copy link
Contributor

@fealho fealho requested review from rwedge and gsheni July 29, 2025 16:03
@fealho fealho marked this pull request as ready for review July 29, 2025 16:04
@fealho fealho requested a review from a team as a code owner July 29, 2025 16:04
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.07%. Comparing base (647b5c9) to head (62b072f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2632      +/-   ##
==========================================
- Coverage   98.08%   98.07%   -0.02%     
==========================================
  Files          70       70              
  Lines        7416     7419       +3     
==========================================
+ Hits         7274     7276       +2     
- Misses        142      143       +1     
Flag Coverage Δ
integration 75.92% <100.00%> (-0.17%) ⬇️
unit 96.84% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fealho fealho merged commit c8a0f7d into main Jul 30, 2025
47 checks passed
@fealho fealho deleted the issue-2553-empty-metadata branch July 30, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata validation should error if metadata is empty
4 participants