Skip to content

Add workflow to run SDGym monthly and publish results #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

R-Palazzo
Copy link
Contributor

CU-86b5qr8wj
Resolve #425

@R-Palazzo R-Palazzo requested review from amontanez24 and fealho July 24, 2025 14:43
@R-Palazzo R-Palazzo self-assigned this Jul 24, 2025
@R-Palazzo R-Palazzo requested a review from a team as a code owner July 24, 2025 14:43
@sdv-team
Copy link
Contributor

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.10%. Comparing base (a42da1f) to head (584f3a7).

Files with missing lines Patch % Lines
sdgym/run_benchmark/upload_benchmark_results.py 78.08% 16 Missing ⚠️
sdgym/benchmark.py 70.37% 8 Missing ⚠️
sdgym/sdgym_result_explorer/result_handler.py 11.11% 8 Missing ⚠️
sdgym/cli/utils.py 42.85% 4 Missing ⚠️
sdgym/cli/collect.py 33.33% 2 Missing ⚠️
sdgym/run_benchmark/run_benchmark.py 93.54% 2 Missing ⚠️
sdgym/cli/__main__.py 0.00% 1 Missing ⚠️
sdgym/sdgym_result_explorer/result_explorer.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   70.97%   72.10%   +1.12%     
==========================================
  Files          24       27       +3     
  Lines        1840     2029     +189     
==========================================
+ Hits         1306     1463     +157     
- Misses        534      566      +32     
Flag Coverage Δ
integration 56.91% <42.64%> (-0.27%) ⬇️
unit 62.39% <81.81%> (+2.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@R-Palazzo R-Palazzo removed the request for review from a team July 24, 2025 16:20
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@R-Palazzo R-Palazzo force-pushed the issue-425-workflow-sdgym branch from e928db0 to e63a58d Compare August 4, 2025 13:46
- issue-425-workflow-sdgym
workflow_dispatch:
schedule:
- cron: '0 5 5 * *'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be updated. Since I launched one today, I think every month on the 5th makes sense.

from sdgym.s3 import parse_s3_path

OUTPUT_DESTINATION_AWS = 's3://sdgym-benchmark/Benchmarks/'
UPLOAD_DESTINATION_AWS = 's3://sdgym-benchmark/Benchmarks/'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with the Github location, I'm also uploading the summary there so we have a backup.

--base gatsby-home \
--title "Upload SDGym Benchmark Results ($FOLDER_NAME)" \
--body "Automated benchmark results upload" \
--reviewer "pcarapic15"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we automerge this instead of having predrag approve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add workflow to run SDGym monthly and publish results
4 participants