-
Notifications
You must be signed in to change notification settings - Fork 116
Add create pull request and auto-merge PR to release workflow #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create pull request and auto-merge PR to release workflow #479
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 29 29
Lines 1826 1826
=======================================
Hits 1646 1646
Misses 180 180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to mention this but you will have to update the make release
command because it creates the tag automatically and we said that we would create the tag on github when publishing the release. We should also update the release notes to match this
RELEASE.md
Outdated
@@ -236,7 +236,7 @@ the type of release that we want to make: | |||
|
|||
### Update the release on GitHub | |||
|
|||
Once the tag and the release to PyPi has been made, go to GitHub and edit the freshly created "tag" to | |||
Once the tag and the release to PyPI has been made, go to GitHub and edit the freshly created "tag" to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tag would not have been made yet in this case. The releaser will need to create the tag through the UI
Co-authored-by: Roy Wedge <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.