Vmd pch rootbus #3

sdurawa · 2024-10-21T16:04:46Z

VMD PCH rootbus implementation

mtkaczyk

patch 1 review
for title I suggest to remove reference to Intel CPU code number (not needed here):

PCI: vmd: Clean up vmd_enable_domain function
This function is too long and needs to be shortened to make it more readable.

This clean up is a prework for enablement additional VMD bus range. It doesn't change
Functional behavior of vmd_enable_domain().

Suggested-by: Nirmal Patel <[email protected]>
Signed-off-by: Szymon Durawa <[email protected]>

typo beahvior

mtkaczyk · 2024-10-22T09:23:36Z

drivers/pci/controller/vmd.c

I've never seen something like that before, probably visual formatting.

mtkaczyk · 2024-10-22T09:25:34Z

drivers/pci/controller/vmd.c

not acceptable:

Suggested change

max_buses = resource_size(&vmd->resources[VMD_RESOURCE_CFGBAR]);

u16 bus;

u16 max_buses = resource_size(&vmd->resources[VMD_RESOURCE_CFGBAR]);

mtkaczyk · 2024-10-22T09:30:03Z

drivers/pci/controller/vmd.c

For sure, it is badly formatted.

Suggested change

&vmd->resources[VMD_RESOURCE_MEMBAR_1];

struct x *vmd_membar1_res=&vmd->dev->resource[VMD_MEMBAR1];

struct x *vmd_membar2_res =&vmd->dev->resource[VMD_MEMBAR2];

vmd_membar1_res->child =&vmd->dev->resource[VMD_MEMBAR1];

vmd_membar2_res->child =&vmd->dev->resource[VMD_MEMBAR2];

mtkaczyk · 2024-10-22T09:31:02Z

drivers/pci/controller/vmd.c

Suggested change

struct resource *res;

struct resource *res = &vmd->dev->resource[VMD_CFGBAR];

mtkaczyk · 2024-10-22T09:32:33Z

drivers/pci/controller/vmd.c

Highlight that it can be NULL.

I mean @parent lol :)

mtkaczyk · 2024-10-22T09:33:24Z

drivers/pci/controller/vmd.c

you say type but the name has number

mtkaczyk · 2024-10-22T09:34:39Z

drivers/pci/controller/vmd.c

generally overwriting income parameter is bad practice, maybe better. use inline if?

.parent = parent ? parent : res;

mtkaczyk · 2024-10-22T09:36:31Z

drivers/pci/controller/vmd.c

looks like bad formatting to me, please look into kernel, how they solve this :)

mtkaczyk · 2024-10-22T09:36:52Z

drivers/pci/controller/vmd.c

bad formatting.

mtkaczyk · 2024-10-22T09:42:11Z

drivers/pci/controller/vmd.c

bad formating

mtkaczyk · 2024-10-22T09:42:51Z

drivers/pci/controller/vmd.c

You can move it up to previous line, lgtm anyway

mtkaczyk · 2024-10-22T09:44:48Z

drivers/pci/controller/vmd.c

I'm not sure if this is correct in kernel coding style :(

mtkaczyk · 2024-10-22T09:46:21Z

drivers/pci/controller/vmd.c

consider shorter naming for variables.

mtkaczyk · 2024-10-22T09:48:56Z

drivers/pci/controller/vmd.c

This function is too long and needs to be shortened to make it more readable. Certain VMD devices like Intel Arrow Lake has two bus ranges, current implementation supports only one range. This clean up is a prework for enablement additional VMD bus range. It doesn't change functional behavior of vmd_enable_domain(). Suggested-by: Nirmal Patel <[email protected]> Reviewed-by: Mariusz Tkaczyk <[email protected]> Signed-off-by: Szymon Durawa <[email protected]>

Starting from Intel Arrow Lake VMD enhacement introduces separate rotbus for PCH. It means that all 3 MMIO BARs exposed by VMD are shared now between CPU IOC and PCH. This patch adds PCH bus enumeration and MMIO management for devices with VMD enhancement support. Suggested-by: Nirmal Patel <[email protected]> Reviewed-by: Mariusz Tkaczyk <[email protected]> Signed-off-by: Szymon Durawa <[email protected]>

VMD PCH rootbus primary number is 0x80 and pci_scan_bridge_extend() cannot assign it as "hard-wired to 0" and marks setup as broken. To avoid this, PCH bus number has to be the same as PCH primary number. Suggested-by: Nirmal Patel <[email protected]> Reviewed-by: Mariusz Tkaczyk <[email protected]> Signed-off-by: Szymon Durawa <[email protected]>

mtkaczyk · 2024-10-22T15:57:03Z

drivers/pci/controller/vmd.c

I mean @parent lol :)

mtkaczyk · 2024-10-23T06:07:05Z

drivers/pci/controller/vmd.c

+	pci_add_resource_offset(&resources_pch,
+				&vmd->resources[VMD_RES_PCH_MEMBAR_2], offset[1]);
+
+	vmd->bus[VMD_ROOTBUS_1] = pci_create_root_bus(


this formatting is bad.

sdurawa force-pushed the vmd_pch_rootbus branch from e6e2d3d to 893f31f Compare October 22, 2024 08:13

mtkaczyk reviewed Oct 22, 2024

View reviewed changes

drivers/pci/controller/vmd.c Outdated

Copy link

mtkaczyk Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formating

sdurawa force-pushed the vmd_pch_rootbus branch from 893f31f to c4ede08 Compare October 22, 2024 14:33

Szymon Durawa added 3 commits October 22, 2024 17:31

mtkaczyk reviewed Oct 23, 2024

View reviewed changes

	max_buses = resource_size(&vmd->resources[VMD_RESOURCE_CFGBAR]);
	u16 bus;
	u16 max_buses = resource_size(&vmd->resources[VMD_RESOURCE_CFGBAR]);

-		&vmd->resources[VMD_RESOURCE_MEMBAR_1];
+struct x *vmd_membar1_res=&vmd->dev->resource[VMD_MEMBAR1];
+struct x *vmd_membar2_res =&vmd->dev->resource[VMD_MEMBAR2];
+vmd_membar1_res->child =&vmd->dev->resource[VMD_MEMBAR1];
+vmd_membar2_res->child =&vmd->dev->resource[VMD_MEMBAR2];

	struct resource *res;
	struct resource *res = &vmd->dev->resource[VMD_CFGBAR];

Vmd pch rootbus #3

Are you sure you want to change the base?

Vmd pch rootbus #3

Uh oh!

Conversation

sdurawa commented Oct 21, 2024

Uh oh!

mtkaczyk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants