session: Fix typedef type size resolution in capture_object #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When capturing objects, the code accessed obj.type_.size directly which fails for typedef types with 'AttributeError: typedef type does not have a size'. Instead of giving up on these types, use drgn.sizeof(obj.type_) which properly resolves typedefs to get the underlying type's actual size. This allows capturing variables like zfs_dbgmsgs and spa_namespace_avl that are typedef'd list/avl structures. Signed-off-by: Serapheim Dimitropoulos <sdimitropoulos@coreweave.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When capturing objects, the code accessed obj.type_.size directly which fails for typedef types with 'AttributeError: typedef type does not have a size'.
Instead of giving up on these types, use drgn.sizeof(obj.type_) which properly resolves typedefs to get the underlying type's actual size.
This allows capturing variables like zfs_dbgmsgs and spa_namespace_avl that are typedef'd list/avl structures.