Skip to content

Conversation

@ilan-gold
Copy link
Contributor

No description provided.

@github-actions
Copy link

A PR has been generated to the instance repo:
scverse/cookiecutter-scverse-instance#234

You can check out the PR to preview your changes
in an instance of the cookiecutter template. The PR will be kept in sync with
this PR automatically.

@ilan-gold ilan-gold requested a review from Zethson November 14, 2025 21:08
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I wonder though whether we want this in the first place (I know that you've adopted it already.

  1. Should all ecosystem packages have such a strict requirement? I'm not sure.
  2. I know that we want this but honestly a lot of people can't or won't do it. I wonder whether we'd limit the reported issue this way because it'd make reporting harder. Even if this is optional.

I'd be happy to also hear opinions from @grst and maybe @LucaMarconato

@ilan-gold
Copy link
Contributor Author

I would be open to making it optional, but strongly encouraged.

@grst
Copy link
Collaborator

grst commented Nov 15, 2025

We had a PR with something similar (though pre-uv) and dismissed it: #62

Main arguments back then were:

  • some users may be intimidated, and bad bug reports are better than no bug reports
  • not all bugs fit into the schema "ran this code, got this error"

If someone doesn't bother to make a reproducible example already now, they'll also leave the new field empty if it's optional.

@ilan-gold
Copy link
Contributor Author

If someone doesn't bother to make a reproducible example already now, they'll also leave the new field empty if it's optional.

I will say, the motivation was that we got a bug report that was "incomplete" and my feeling was that if we made this process easier, we would have gotten a complete one (and then could have fixed the issue in 1 day instead of waiting 2 months to get enough repro info).

@flying-sheep
Copy link
Member

flying-sheep commented Nov 16, 2025

we got a bug report that was "incomplete"

we constantly get a lot of them, and most are a waste of time since we try to reproduce and then just can’t.

I think whatever we can to do inspire people to post more complete examples, that would be ideal

@Zethson
Copy link
Member

Zethson commented Nov 16, 2025

Since you've already applied this change to Anndata and/or scanpy, I suggest that we observe what your experiences are before merging this change.
Do you see an uptick in reproducible issues or are you suddenly getting a lot less issues? Let's find out.

Wdyt?

@ilan-gold
Copy link
Contributor Author

I'm fine waiting. I'm glad that we started the discussion then :) Let's see!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants