-
Notifications
You must be signed in to change notification settings - Fork 14
feat: runnable bug repots #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
A PR has been generated to the instance repo: You can check out the PR to preview your changes |
Zethson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. I wonder though whether we want this in the first place (I know that you've adopted it already.
- Should all ecosystem packages have such a strict requirement? I'm not sure.
- I know that we want this but honestly a lot of people can't or won't do it. I wonder whether we'd limit the reported issue this way because it'd make reporting harder. Even if this is optional.
I'd be happy to also hear opinions from @grst and maybe @LucaMarconato
|
I would be open to making it optional, but strongly encouraged. |
|
We had a PR with something similar (though pre-uv) and dismissed it: #62 Main arguments back then were:
If someone doesn't bother to make a reproducible example already now, they'll also leave the new field empty if it's optional. |
I will say, the motivation was that we got a bug report that was "incomplete" and my feeling was that if we made this process easier, we would have gotten a complete one (and then could have fixed the issue in 1 day instead of waiting 2 months to get enough repro info). |
we constantly get a lot of them, and most are a waste of time since we try to reproduce and then just can’t. I think whatever we can to do inspire people to post more complete examples, that would be ideal |
|
Since you've already applied this change to Anndata and/or scanpy, I suggest that we observe what your experiences are before merging this change. Wdyt? |
|
I'm fine waiting. I'm glad that we started the discussion then :) Let's see! |
No description provided.