fix: don't materialize obs until writing
#85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few things this PR does to minimize memory usage from
obs:AnnDataobjects, whether viaanndata.concator by io, I think we should probably makeremove_unused_categories=Falsethe default in the library where possible especially given the target application of deep learning where you really want those categories + codes to be correct. I've added something to the README about thish5 performance is still relatively bad memory-wise because you have to ready string arrays into memory (this comes from
anndata, the alternative of wrapping them as dask arrays is somehow even slower).