Skip to content

Conversation

Nishthajain7
Copy link
Contributor

Contributor checklist


Description

  • Auto suggest UI is handled by SuggestionHelper
  • Moved word suggestions to SugggestionHandler
  • Created a separate helper for ConjugateHandler class

Related issue

Copy link

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting, formatting and testing workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@Nishthajain7 Nishthajain7 force-pushed the code-refactor branch 3 times, most recently from 7f5edf3 to 3e6ef71 Compare September 27, 2025 04:50
@Nishthajain7
Copy link
Contributor Author

@andrewtavis Sorry for the delay. I completed this a few weeks ago and thought I made the PR but I realized I didn't. The GeneralKeyboard file still has ~1700 lines and I am sure it can be further improved. I'd like to know your suggestions on this. Thank you!

@andrewtavis
Copy link
Member

Thanks so much for the PR, @Nishthajain7! We'll get to the review in the coming days :) :)

@andrewtavis
Copy link
Member

Would you be able to check out the failing instrumentation tests though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants